Files
resolutionflow/docs/plans/2026-02-25-flow-to-library-sync-design.md
chihlasm e6a0c0549b feat: Step Library sync + service account for default tree ownership
* feat: maintenance flow UX redesign — batch status hub, context strip, detail page upgrades (#85)

- Add BatchStatusPage (/flows/:id/batches/:batchId): per-target Start/Resume/View cards, progress bar, 5s polling while in-progress, completion outcome summary
- Add BatchStatusCard: handles not-started/in-progress/complete states with step progress for in-progress targets
- Add ActiveBatchBanner: amber banner on detail page when a batch is running, links to BatchStatusPage
- Add MaintenanceContextStrip: amber strip in ProceduralNavigationPage for maintenance flows showing target name, batch progress (X/Y complete), and Back to Batch nav
- Update MaintenanceFlowDetailPage: active batch banner, clickable run history rows with mini progress dots and outcome summaries, Run button loading state, post-launch navigates to BatchStatusPage
- Update ProceduralNavigationPage: renders MaintenanceContextStrip between top bar and content when tree_type === 'maintenance'; fetches batch progress once on mount
- Add batch_id filter to GET /sessions backend endpoint and SessionListParams frontend type
- Add /flows/:id/batches/:batchId route to router

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: session detail page — completion action + outcome summary card

- In-progress sessions: amber banner with "Complete Session" button opens
  SessionOutcomeModal to set outcome/notes/next-steps and finalize
- Completed sessions: colored outcome summary card (icon + outcome label +
  duration + notes + next steps) replaces dense header metadata; "Copy for
  Ticket" promoted to primary action inside the card
- Export toolbar de-emphasized to secondary row of smaller controls below
  the summary card

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: add library-page action props to StepCard (edit/delete/save)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: pass library-page action props through StepLibraryBrowser + refreshKey

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: StepFormModal wrapper + submitLabel/isSubmitting props on StepForm

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: Step Library page — create, edit, delete, save-to-library

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: add RuntimeStep union type for procedural custom steps

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: StepChecklist accepts RuntimeStep[], renders amber Custom badge

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: StepDetail accepts RuntimeStep, renders Custom Step badge for custom steps

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: custom step insertion in procedural flow sessions

Engineers can add custom steps inline during execution. Steps are
persisted to session.custom_steps and restored on resume.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: suppress StepFeedback on custom steps, fix resume stepState seeding, functional updater for step index

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* docs: add tree forking UI design doc

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* docs: add tree fork UI implementation plan

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: add ForkInfo type and fork fields to Tree/TreeListItem

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: align ForkInfo type with backend schema, remove redundant fork fields

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: ForkInfo placement, required fork_info field, add JSDoc

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: add ForkModal component with name and reason fields

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: ForkModal accessibility and UX (escape, click-outside, labels, maxLength)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: open ForkModal on fork action in TreeLibraryPage

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: add ForkModal to MyTreesPage

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: show Fork chip badge on forked tree cards

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* docs: add flow-to-library step sync design doc

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* docs: add flow-to-library sync implementation plan

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: add sync tracking columns to step_library

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: add sync columns and source_tree relationship to StepLibrary model

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: add group_label to StepContent, is_flow_synced/source_tree_name to StepLibraryResponse

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: include is_flow_synced and source_tree_name in step list/detail responses

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: add is_flow_synced and source_tree_name to step list response

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: add selectinload and sync fields to search and get_step endpoints

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: add step_sync module with extraction and upsert logic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: safe NOT IN placeholders for asyncpg, add deactivate docstring

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: trigger step library sync on tree publish and deactivate on delete

- Call sync_steps_from_tree in update_tree whenever the tree is published
  (status transitions to 'published' or is already published and structure changes)
- Call deactivate_synced_steps_for_tree in delete_tree before db.commit()
  so the FK SET NULL does not nullify source_tree_id before the WHERE clause runs
- Fix ::jsonb cast syntax in step_sync.py (asyncpg rejects :: operator in text()
  queries; replaced with CAST(:content AS jsonb))
- Add UniqueConstraint('source_tree_id','source_node_id') to StepLibrary model
  so Base.metadata.create_all (used by tests) creates the constraint that the
  ON CONFLICT clause in sync_steps_from_tree depends on

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: add is_flow_synced and source_tree_name to Step types

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: show From Flow badge and lock icon on flow-synced StepCard

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: show source flow name in StepDetailModal for synced steps

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: add Library Visibility select to procedural StepEditor

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: address code review issues in flow-to-library sync

- Fix sync trigger: only fire on publish transition, not every PUT
- Add TestSyncOnPublish integration tests (2 tests, 16 total passing)
- Add group_label to frontend StepContent interface
- Guard Library Visibility select to procedure_step nodes only
- Block API edits to flow-synced steps (400 read-only guard)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: handle None author_id in step sync to avoid invalid UUID error

When a system/default tree has no author (author_id is None),
str(None) produces the literal string 'None' which asyncpg
rejects as an invalid UUID for the created_by column.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: add ResolutionFlow service account to own default tree steps in library

Default/system trees had no author_id (NULL), causing a NOT NULL violation
when syncing steps to step_library.created_by on publish.

- Add is_service_account flag to users table (migration 4f4137ce)
- Add service_account.py: idempotent ensure_service_account() creates
  noreply@resolutionflow.com with unusable password on startup
- Cache service account ID on app.state at lifespan startup
- Add get_service_account_id() FastAPI dep (returns None in tests)
- sync_steps_from_tree: resolve author_id or service_account_id as created_by
- create_tree: set author_id=service_account_id for is_default trees
- Migration 1490781700bc: backfill author_id on 31 existing default trees

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-02-25 23:17:29 -05:00

8.0 KiB

Flow-to-Library Step Sync Design

Date: 2026-02-25 Feature: Automatically sync steps from published flows into the step library


Overview

When a flow is published, its steps are extracted and written into the step_library table so engineers can discover and reuse them when building new flows or inserting ad-hoc steps during a live session. Library entries are flow-owned and read-only — forking creates a personal copy for customization.

What gets synced:

  • procedural / maintenance flows → each procedure_step node → step_type: 'action'
  • troubleshooting flows → each action node → step_type: 'action'; each solution node → step_type: 'solution'
  • section_header and procedure_end nodes are NOT synced as library entries

Sync trigger: PUT /trees/{tree_id} when status transitions to 'published'

Sync model: Upsert keyed on (source_tree_id, source_node_id) — subsequent publishes update existing entries without losing usage counts or ratings.


Section 1: Data Model

New columns on step_library (one migration)

Column Type Default Notes
source_tree_id UUID FK → trees.id NULL SET NULL on tree delete
source_node_id String(255) NULL Node id within tree_structure JSONB
is_flow_synced Boolean false Distinguishes synced from manually created entries
last_synced_at DateTime(timezone=True) NULL Timestamp of last sync

New optional field on StepContent schema

Add group_label: Optional[str] = None to StepContent in backend/app/schemas/step_library.py. For procedural steps that belong to a section, this stores the section header title so steps are browsable/filterable by section in the library.

Per-step visibility override on procedural step nodes

Add optional library_visibility field to individual step nodes in tree_structure JSONB:

  • Type: 'team' | 'public' (no 'private' — synced steps are always at minimum team-visible)
  • If absent: inherits visibility from the flow (default behavior)
  • Stored directly on the step node in tree_structure — no schema migration needed (JSONB is flexible)

Visibility inheritance mapping

Flow state Resolved step visibility
is_public=True 'public'
is_public=False, has account_id 'team'
is_public=False, no account_id 'team'
Step has library_visibility set Use that value (overrides above)

On flow deactivation / deletion

When is_active is set to False on a tree, or the tree is deleted, soft-delete all synced library entries for that tree: UPDATE step_library SET is_active=False WHERE source_tree_id=:tree_id AND is_flow_synced=True.

Forked copies (is_flow_synced=False, different created_by) are unaffected.


Section 2: Sync Logic (Backend)

Trigger location

backend/app/api/endpoints/trees.pyupdate_tree() function, after the block at line ~587 where status is confirmed to be transitioning to 'published'.

Extraction logic

For procedural/maintenance flows:

steps = tree_structure.get('steps', [])
for node in steps:
    if node['type'] != 'procedure_step':
        continue
    # find the most recent section_header preceding this step
    group_label = last_seen_section_header_title
    yield StepLibraryUpsert(
        title=node['title'],
        step_type='action',
        content=StepContent(
            instructions=node.get('description') or node['title'],
            help_text=node.get('expected_outcome'),
            commands=[StepCommand(label=c.get('label',''), command=c['code'], command_type=c.get('language'))
                      for c in normalize_commands(node.get('commands'))],
            group_label=group_label,
        ),
        visibility=node.get('library_visibility') or resolve_visibility(tree),
        source_tree_id=tree.id,
        source_node_id=node['id'],
    )

For troubleshooting flows:

walk all nodes recursively
for node with type in ('action', 'solution'):
    yield StepLibraryUpsert(
        title=node['title'],
        step_type='action' if node['type']=='action' else 'solution',
        content=StepContent(
            instructions=node.get('description') or node['title'],
        ),
        visibility=resolve_visibility(tree),
        source_tree_id=tree.id,
        source_node_id=node['id'],
    )

Command normalization: node.commands can be a plain string or an array of {language, code, label} objects. Normalize both into StepCommand list.

Upsert query

INSERT INTO step_library (id, title, step_type, content, visibility, created_by,
    account_id, is_flow_synced, source_tree_id, source_node_id, last_synced_at, ...)
VALUES (...)
ON CONFLICT (source_tree_id, source_node_id)
DO UPDATE SET
    title = EXCLUDED.title,
    content = EXCLUDED.content,
    visibility = EXCLUDED.visibility,
    last_synced_at = EXCLUDED.last_synced_at,
    is_active = true  -- re-activate if previously soft-deleted

Requires a unique constraint on (source_tree_id, source_node_id).

created_by for synced entries

Set to the tree's author_id. This gives the flow author "ownership" of the entry, consistent with the flow-owned model. Permissions in core/permissions.py already allow the creator to see their own private steps — no change needed.


Section 3: Per-Step Visibility Override (Editor)

Where

frontend/src/components/procedural-editor/StepEditor.tsx — inside the existing "More Options" collapsible section.

What

A "Library Visibility" select field, shown only for procedure_step nodes (not section headers, not end nodes):

Library Visibility
[ Inherit from flow ▼ ]   (options: Inherit from flow / Team only / Public)
  • Default (no library_visibility on node): renders as "Inherit from flow"
  • Selecting "Team only" or "Public" writes library_visibility: 'team' or library_visibility: 'public' to the node
  • Selecting "Inherit from flow" removes the library_visibility key from the node

Only rendered when tree_type is 'procedural' or 'maintenance'. Troubleshooting flows have no per-node override (they inherit the flow visibility always).


Section 4: Frontend — Step Library Browser

Changes to StepLibraryBrowser / step list

  • "From Flow" badge on synced entries (is_flow_synced: true): small chip — same style as existing type badges. Shows source flow name.
  • Step detail/preview panel: add "Sourced from: [Flow Name]" line with a link to the flow's navigate/edit page.
  • Read-only indicator: for is_flow_synced entries, replace the Edit button with a lock icon + tooltip: "Managed by source flow — fork to customize."
  • Fork behavior: existing "Save to Library" copy mechanism unchanged. Forked copy gets is_flow_synced=false, source_tree_id=null, created_by=current_user.

API response changes

StepLibraryResponse needs two new fields:

  • is_flow_synced: bool
  • source_tree_name: Optional[str] — joined from trees.name at query time

Files Changed

File Change
backend/alembic/versions/030_add_step_library_sync_fields.py New migration — add 4 columns + unique constraint
backend/app/models/step_library.py Add 4 new columns + FK relationship to Tree
backend/app/schemas/step_library.py Add group_label to StepContent; add is_flow_synced + source_tree_name to response schema
backend/app/api/endpoints/trees.py Add sync logic after publish transition
backend/app/core/step_sync.py New module — extraction + upsert logic (keeps trees.py clean)
backend/tests/test_step_sync.py New test file
frontend/src/types/step.ts Add is_flow_synced, source_tree_name to Step type
frontend/src/components/procedural-editor/StepEditor.tsx Add Library Visibility select in More Options
frontend/src/components/step-library/StepLibraryBrowser.tsx From Flow badge, read-only indicator, source flow link