chihlasm/resolutionflow
1
0
Fork 0
Code Issues 23 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(prod): production hardening for launch #194

Open
chihlasm wants to merge 2 commits from fix/production-hardening into main
pull from: fix/production-hardening
merge into: chihlasm:main
Conversation 0 Commits 2 Files Changed 10 +73 -14
chihlasm commented 2026-06-12 23:41:29 +00:00
Owner
Copy Link

Resolves the code-level findings from the 2026-06-11 production-readiness audit:

  • Gate Swagger/ReDoc/OpenAPI behind DEBUG
  • Sentry send_default_pii only in dev
  • Dockerfile CMD no longer races migrations with releaseCommand
  • RATE_LIMIT_ENABLED decouples rate limiting from DEBUG (PR envs were unlimited)
  • Boot-time failure when SELF_SERVE_ENABLED without RESEND_API_KEY/ANTHROPIC_API_KEY/FRONTEND_URL
  • Reject localhost OAUTH_REDIRECT_BASE outside DEBUG
  • pool_pre_ping + pool_recycle on the app engine
  • max_instances=1 on 4 scheduler jobs
  • Frontend: DEV-gate stale-async console.warn; Dockerfile VITE_* semantics documented

Ops follow-ups (env-var only, on the Phase O checklist): CSP_REPORT_ONLY=false, RATE_LIMIT_ENABLED=true in prod, pin backend to 1 replica, verify Railway backups.

Resolves the code-level findings from the 2026-06-11 production-readiness audit: - Gate Swagger/ReDoc/OpenAPI behind DEBUG - Sentry send_default_pii only in dev - Dockerfile CMD no longer races migrations with releaseCommand - RATE_LIMIT_ENABLED decouples rate limiting from DEBUG (PR envs were unlimited) - Boot-time failure when SELF_SERVE_ENABLED without RESEND_API_KEY/ANTHROPIC_API_KEY/FRONTEND_URL - Reject localhost OAUTH_REDIRECT_BASE outside DEBUG - pool_pre_ping + pool_recycle on the app engine - max_instances=1 on 4 scheduler jobs - Frontend: DEV-gate stale-async console.warn; Dockerfile VITE_* semantics documented Ops follow-ups (env-var only, on the Phase O checklist): CSP_REPORT_ONLY=false, RATE_LIMIT_ENABLED=true in prod, pin backend to 1 replica, verify Railway backups.
chihlasm added 1 commit 2026-06-12 23:41:30 +00:00
fix(prod): harden production configuration for launch
Some checks failed
Mirror to GitHub / mirror (push) Successful in 5s
Details
CI / frontend (pull_request) Successful in 7m12s
Details
CI / e2e (pull_request) Failing after 6m56s
Details
CI / backend (pull_request) Failing after 9m55s
Details
c4947218a4 
- Gate Swagger/ReDoc/OpenAPI behind DEBUG (no public API schema in prod)
- Sentry send_default_pii only in dev (no auth headers/bodies in events)
- Remove alembic from Dockerfile CMD (releaseCommand owns migrations; CMD copy raced across replicas/restarts)
- Decouple rate limiting from DEBUG via RATE_LIMIT_ENABLED (PR envs with DEBUG=true were unlimited); tests disable the live limiter in conftest
- max_instances=1 on the 4 scheduler jobs missing it
- Boot-time failure when SELF_SERVE_ENABLED without RESEND_API_KEY/ANTHROPIC_API_KEY/FRONTEND_URL
- Reject localhost OAUTH_REDIRECT_BASE outside DEBUG
- pool_pre_ping + pool_recycle on the app engine
- Frontend: DEV-gate stale-async console.warn; document VITE_SELF_SERVE_ENABLED fallback semantics in Dockerfile

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
chihlasm force-pushed fix/production-hardening from 4dc4894fc7 to c4947218a4 2026-06-12 23:41:30 +00:00 Compare
chihlasm added 1 commit 2026-06-13 00:14:08 +00:00
test(e2e): disable rate limiting in the Playwright backend webserver
Some checks failed
Mirror to GitHub / mirror (push) Successful in 4s
Details
CI / frontend (pull_request) Successful in 6m47s
Details
CI / backend (pull_request) Failing after 9m24s
Details
CI / e2e (pull_request) Successful in 10m26s
Details
63e5881972 
RATE_LIMIT_ENABLED now defaults on regardless of DEBUG; the e2e suite
logs in dozens of times per run from one IP and trips the per-minute
auth limits (429 at helpers/api.ts login).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Some checks failed
Mirror to GitHub / mirror (push) Successful in 4s
Details
CI / frontend (pull_request) Successful in 6m47s
Required
Details
CI / backend (pull_request) Failing after 9m24s
Required
Details
CI / e2e (pull_request) Successful in 10m26s
Details
Some required checks were not successful.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/production-hardening:fix/production-hardening
git checkout fix/production-hardening
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
10x-analysis
From 10x product analysis
 backend
FastAPI/Python work
 bug
Something isn't working
 collaboration
Team sharing, escalation, notifications
 database
PostgreSQL/schema changes
 documentation
Documentation updates
 duplicate
This issue or pull request already exists
 enhancement
Improvement to existing feature
 feature
New functionality
 frontend
React work
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 integration
PSA, external service integrations
 intelligence
Analytics, AI, data-driven features
 invalid
This doesn't seem right
 priority: high
Do this soon
 priority: low
Nice to have
 priority: medium
Important but not urgent
 question
Further information is requested
 quick-win
Low effort, high value
 strategic
Long-term strategic bet
 ux
User experience improvements
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
chihlasm
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: chihlasm/resolutionflow#194
Delete Branch "fix/production-hardening"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?