chihlasm/resolutionflow
1
0
Fork 0
Code Issues 23 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(e2e): update 5 selectors that drifted with FlowPilot/PSA UI changes #152

Closed
chihlasm wants to merge 1 commits from fix/e2e-test-selectors into main
pull from: fix/e2e-test-selectors
merge into: chihlasm:main
Conversation 0 Commits 1 Files Changed 4 +20 -6
chihlasm commented 2026-04-25 19:21:45 +00:00
Owner
Copy Link

Superseded by PR #150 — its branch now contains both the xdist parallelization (originally this PR's scope) and the e2e selector fixes. One consolidated CI-recovery PR is easier to land than three stacked ones.

Superseded by PR #150 — its branch now contains both the xdist parallelization (originally this PR's scope) and the e2e selector fixes. One consolidated CI-recovery PR is easier to land than three stacked ones.
chihlasm added 1 commit 2026-04-25 19:21:46 +00:00
fix(e2e): update 5 selectors that drifted with FlowPilot/PSA UI changes
Some checks failed
Mirror to GitHub / mirror (push) Successful in 15s
Details
CI / frontend (pull_request) Failing after 2m37s
Details
CI / e2e (pull_request) Has been skipped
Details
CI / backend (pull_request) Has been cancelled
Details
37c4e0c99e 
Mechanical drift between the e2e selectors and the current UI surfaced
on the first CI run after PR #149 unblocked the artifact upload step.
Five tests, three categories of drift:

1. **Page heading renames** (navigation.spec.ts)
   - `Sessions` → `Session History` on /sessions
   - `Account Settings` → `Account Management` on /account

2. **Route rename** (command-palette.spec.ts:74)
   - The "Troubleshoot with FlowPilot" command palette option now lands
     on /pilot (Phase 1 of the FlowPilot migration renamed /assistant).
     /assistant still 301-redirects, so the assertion accepts either.

3. **Feature moved to /sessions** (history.spec.ts, resume.spec.ts)
   - Default tab on /sessions is "AI Sessions"; flow-session filtering
     and the Resume button moved behind the "Flow Sessions" tab. Both
     tests now click that tab before asserting.
   - resume.spec.ts no longer starts at /trees (Resume buttons aren't
     rendered there anymore — the flow lives on /sessions). Destination
     URL (/trees/:id/navigate) is unchanged.

No product-code changes — these are pure test updates against the
shipped UI. Run the suite locally with
`cd frontend && npm run test:e2e` once a fresh build is available.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
chihlasm closed this pull request 2026-04-25 19:54:09 +00:00
Some checks failed
Mirror to GitHub / mirror (push) Successful in 15s
Details
CI / frontend (pull_request) Failing after 2m37s
Required
Details
CI / e2e (pull_request) Has been skipped
Details
CI / backend (pull_request) Has been cancelled
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
10x-analysis
From 10x product analysis
 backend
FastAPI/Python work
 bug
Something isn't working
 collaboration
Team sharing, escalation, notifications
 database
PostgreSQL/schema changes
 documentation
Documentation updates
 duplicate
This issue or pull request already exists
 enhancement
Improvement to existing feature
 feature
New functionality
 frontend
React work
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 integration
PSA, external service integrations
 intelligence
Analytics, AI, data-driven features
 invalid
This doesn't seem right
 priority: high
Do this soon
 priority: low
Nice to have
 priority: medium
Important but not urgent
 question
Further information is requested
 quick-win
Low effort, high value
 strategic
Long-term strategic bet
 ux
User experience improvements
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
chihlasm
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: chihlasm/resolutionflow#152
Delete Branch "fix/e2e-test-selectors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?