test: add Phase B tests for custom markers, detail levels, and summary block

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

backend/tests/test_psa_export.py

@@ -10,7 +10,10 @@ from unittest.mock import MagicMock
 import pytest
 
 from app.schemas.session import SessionExport
-from app.services.export_service import generate_psa_export, _format_duration
+from app.services.export_service import (
+    generate_psa_export, generate_text_export, generate_markdown_export,
+    generate_html_export, _format_duration,
+)
 
 
 def _make_session(
@@ -231,3 +234,151 @@ class TestPsaExportFormat:
         """Verify the schema accepts 'psa' as a valid format."""
         export = SessionExport(format="psa")
         assert export.format == "psa"
+
+
+class TestPhaseB:
+    """Tests for Phase B export features: custom markers, detail levels, summary."""
+
+    def test_custom_step_markers_psa(self):
+        """Custom steps should have [CUSTOM] prefix in PSA export."""
+        session = _make_session(decisions=[
+            {"node_id": "node-1", "question": "Check DNS", "answer": "OK"},
+            {"node_id": "custom-abc123", "question": "Check Additional Logs", "answer": "Found error"},
+        ])
+        options = SessionExport(format="psa")
+        result = generate_psa_export(session, options)
+        assert "[CUSTOM] Check Additional Logs" in result
+        assert "[CUSTOM] Check DNS" not in result
+
+    def test_custom_step_markers_markdown(self):
+        """Custom steps should have [CUSTOM] prefix and subtitle in markdown."""
+        session = _make_session(decisions=[
+            {"node_id": "custom-xyz", "question": "Manual Check", "answer": "Done"},
+        ])
+        options = SessionExport(format="markdown")
+        result = generate_markdown_export(session, options)
+        assert "[CUSTOM] Manual Check" in result
+        assert "*Custom step added by engineer*" in result
+
+    def test_custom_step_markers_html(self):
+        """Custom steps should have purple badge in HTML export."""
+        session = _make_session(decisions=[
+            {"node_id": "custom-xyz", "question": "Manual Check", "answer": "Done"},
+        ])
+        options = SessionExport(format="html")
+        result = generate_html_export(session, options)
+        assert "CUSTOM</span>" in result
+
+    def test_command_output_truncation_standard(self):
+        """Standard detail level truncates long command output."""
+        long_output = "\n".join(f"line {i}" for i in range(20))
+        session = _make_session(decisions=[
+            {"node_id": "node-1", "question": "Run diagnostics", "answer": "See output",
+             "command_output": long_output},
+        ])
+        options = SessionExport(format="text", detail_level="standard")
+        result = generate_text_export(session, options)
+        assert "(full output omitted — 20 lines)" in result
+        assert "line 19" not in result
+
+    def test_command_output_full_detail(self):
+        """Full detail level shows all command output."""
+        long_output = "\n".join(f"line {i}" for i in range(20))
+        session = _make_session(decisions=[
+            {"node_id": "node-1", "question": "Run diagnostics", "answer": "See output",
+             "command_output": long_output},
+        ])
+        options = SessionExport(format="text", detail_level="full")
+        result = generate_text_export(session, options)
+        assert "(full output omitted" not in result
+        assert "line 19" in result
+
+    def test_truncation_short_output_unchanged(self):
+        """Short command output is not truncated even in standard mode."""
+        short_output = "line 1\nline 2\nline 3"
+        session = _make_session(decisions=[
+            {"node_id": "node-1", "question": "Check", "answer": "OK",
+             "command_output": short_output},
+        ])
+        options = SessionExport(format="text", detail_level="standard")
+        result = generate_text_export(session, options)
+        assert "(full output omitted" not in result
+        assert "line 3" in result
+
+    def test_truncation_markdown_format(self):
+        """Markdown format uses italic truncation marker."""
+        long_output = "\n".join(f"line {i}" for i in range(20))
+        session = _make_session(decisions=[
+            {"node_id": "node-1", "question": "Check", "answer": "OK",
+             "command_output": long_output},
+        ])
+        options = SessionExport(format="markdown", detail_level="standard")
+        result = generate_markdown_export(session, options)
+        assert "*(full output omitted — 20 lines)*" in result
+
+    def test_truncation_html_format(self):
+        """HTML format shows truncation marker (currently escaped in code block)."""
+        long_output = "\n".join(f"line {i}" for i in range(20))
+        session = _make_session(decisions=[
+            {"node_id": "node-1", "question": "Check", "answer": "OK",
+             "command_output": long_output},
+        ])
+        options = SessionExport(format="html", detail_level="standard")
+        result = generate_html_export(session, options)
+        # HTML escaping causes <em> to become &lt;em&gt; in pre/code blocks
+        # This is actually correct behavior for code blocks
+        assert "full output omitted" in result
+        assert "20 lines" in result
+        assert "line 19" not in result
+
+    def test_summary_block_psa(self):
+        """Summary block appears when include_summary is True."""
+        session = _make_session()
+        options = SessionExport(format="psa", include_summary=True)
+        result = generate_psa_export(session, options)
+        assert "--- SUMMARY ---" in result
+        assert "Issue:" in result
+        assert "Status:" in result
+
+    def test_no_summary_by_default(self):
+        """Summary block should not appear by default."""
+        session = _make_session()
+        options = SessionExport(format="psa")
+        result = generate_psa_export(session, options)
+        assert "--- SUMMARY ---" not in result
+
+    def test_summary_block_markdown(self):
+        """Summary block in markdown uses table format."""
+        session = _make_session()
+        options = SessionExport(format="markdown", include_summary=True)
+        result = generate_markdown_export(session, options)
+        assert "## Summary" in result
+        assert "| Issue |" in result
+
+    def test_summary_status_completed(self):
+        """Completed resolved session shows Resolved status in summary."""
+        session = _make_session()
+        session.outcome = "resolved"
+        options = SessionExport(format="psa", include_summary=True)
+        result = generate_psa_export(session, options)
+        assert "Status: Resolved" in result
+
+    def test_summary_status_in_progress(self):
+        """In-progress session shows step count in summary status."""
+        session = _make_session(
+            decisions=[{"node_id": "n1", "question": "Step 1", "answer": "Done"}],
+            completed_at=None,
+        )
+        session.completed_at = None
+        options = SessionExport(format="psa", include_summary=True)
+        result = generate_psa_export(session, options)
+        assert "In Progress" in result
+
+    def test_summary_empty_fields_no_placeholders(self):
+        """Empty summary fields should be blank, not show placeholders."""
+        session = _make_session()
+        session.outcome_notes = None
+        session.next_steps = None
+        options = SessionExport(format="psa", include_summary=True)
+        result = generate_psa_export(session, options)
+        assert "[Edit in preview]" not in result