feat: Step Library sync + service account for default tree ownership
* feat: maintenance flow UX redesign — batch status hub, context strip, detail page upgrades (#85) - Add BatchStatusPage (/flows/:id/batches/:batchId): per-target Start/Resume/View cards, progress bar, 5s polling while in-progress, completion outcome summary - Add BatchStatusCard: handles not-started/in-progress/complete states with step progress for in-progress targets - Add ActiveBatchBanner: amber banner on detail page when a batch is running, links to BatchStatusPage - Add MaintenanceContextStrip: amber strip in ProceduralNavigationPage for maintenance flows showing target name, batch progress (X/Y complete), and Back to Batch nav - Update MaintenanceFlowDetailPage: active batch banner, clickable run history rows with mini progress dots and outcome summaries, Run button loading state, post-launch navigates to BatchStatusPage - Update ProceduralNavigationPage: renders MaintenanceContextStrip between top bar and content when tree_type === 'maintenance'; fetches batch progress once on mount - Add batch_id filter to GET /sessions backend endpoint and SessionListParams frontend type - Add /flows/:id/batches/:batchId route to router Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: session detail page — completion action + outcome summary card - In-progress sessions: amber banner with "Complete Session" button opens SessionOutcomeModal to set outcome/notes/next-steps and finalize - Completed sessions: colored outcome summary card (icon + outcome label + duration + notes + next steps) replaces dense header metadata; "Copy for Ticket" promoted to primary action inside the card - Export toolbar de-emphasized to secondary row of smaller controls below the summary card Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: add library-page action props to StepCard (edit/delete/save) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: pass library-page action props through StepLibraryBrowser + refreshKey Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: StepFormModal wrapper + submitLabel/isSubmitting props on StepForm Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: Step Library page — create, edit, delete, save-to-library Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: add RuntimeStep union type for procedural custom steps Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: StepChecklist accepts RuntimeStep[], renders amber Custom badge Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: StepDetail accepts RuntimeStep, renders Custom Step badge for custom steps Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: custom step insertion in procedural flow sessions Engineers can add custom steps inline during execution. Steps are persisted to session.custom_steps and restored on resume. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: suppress StepFeedback on custom steps, fix resume stepState seeding, functional updater for step index Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * docs: add tree forking UI design doc Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * docs: add tree fork UI implementation plan Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: add ForkInfo type and fork fields to Tree/TreeListItem Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: align ForkInfo type with backend schema, remove redundant fork fields Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: ForkInfo placement, required fork_info field, add JSDoc Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: add ForkModal component with name and reason fields Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: ForkModal accessibility and UX (escape, click-outside, labels, maxLength) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: open ForkModal on fork action in TreeLibraryPage Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: add ForkModal to MyTreesPage Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: show Fork chip badge on forked tree cards Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * docs: add flow-to-library step sync design doc Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * docs: add flow-to-library sync implementation plan Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: add sync tracking columns to step_library Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: add sync columns and source_tree relationship to StepLibrary model Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: add group_label to StepContent, is_flow_synced/source_tree_name to StepLibraryResponse Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: include is_flow_synced and source_tree_name in step list/detail responses Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: add is_flow_synced and source_tree_name to step list response Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: add selectinload and sync fields to search and get_step endpoints Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: add step_sync module with extraction and upsert logic Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: safe NOT IN placeholders for asyncpg, add deactivate docstring Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: trigger step library sync on tree publish and deactivate on delete - Call sync_steps_from_tree in update_tree whenever the tree is published (status transitions to 'published' or is already published and structure changes) - Call deactivate_synced_steps_for_tree in delete_tree before db.commit() so the FK SET NULL does not nullify source_tree_id before the WHERE clause runs - Fix ::jsonb cast syntax in step_sync.py (asyncpg rejects :: operator in text() queries; replaced with CAST(:content AS jsonb)) - Add UniqueConstraint('source_tree_id','source_node_id') to StepLibrary model so Base.metadata.create_all (used by tests) creates the constraint that the ON CONFLICT clause in sync_steps_from_tree depends on Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: add is_flow_synced and source_tree_name to Step types Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: show From Flow badge and lock icon on flow-synced StepCard Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: show source flow name in StepDetailModal for synced steps Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: add Library Visibility select to procedural StepEditor Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: address code review issues in flow-to-library sync - Fix sync trigger: only fire on publish transition, not every PUT - Add TestSyncOnPublish integration tests (2 tests, 16 total passing) - Add group_label to frontend StepContent interface - Guard Library Visibility select to procedure_step nodes only - Block API edits to flow-synced steps (400 read-only guard) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: handle None author_id in step sync to avoid invalid UUID error When a system/default tree has no author (author_id is None), str(None) produces the literal string 'None' which asyncpg rejects as an invalid UUID for the created_by column. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: add ResolutionFlow service account to own default tree steps in library Default/system trees had no author_id (NULL), causing a NOT NULL violation when syncing steps to step_library.created_by on publish. - Add is_service_account flag to users table (migration 4f4137ce) - Add service_account.py: idempotent ensure_service_account() creates noreply@resolutionflow.com with unusable password on startup - Cache service account ID on app.state at lifespan startup - Add get_service_account_id() FastAPI dep (returns None in tests) - sync_steps_from_tree: resolve author_id or service_account_id as created_by - create_tree: set author_id=service_account_id for is_default trees - Migration 1490781700bc: backfill author_id on 31 existing default trees Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit was merged in pull request #89.
This commit is contained in:
chihlasm
46
frontend/src/components/maintenance/ActiveBatchBanner.tsx
Normal file
46
frontend/src/components/maintenance/ActiveBatchBanner.tsx
Normal file
@@ -0,0 +1,46 @@
|
||||
import { X, RefreshCw, ChevronRight } from 'lucide-react'
|
||||
import { useNavigate } from 'react-router-dom'
|
||||
import type { Session } from '@/types'
|
||||
|
||||
interface ActiveBatchBannerProps {
|
||||
treeId: string
|
||||
sessions: Session[]
|
||||
onDismiss: () => void
|
||||
}
|
||||
|
||||
export function ActiveBatchBanner({ treeId, sessions, onDismiss }: ActiveBatchBannerProps) {
|
||||
const navigate = useNavigate()
|
||||
|
||||
// Find the most recently started in-progress batch
|
||||
const inProgressSessions = sessions.filter(s => s.started_at && !s.completed_at && s.batch_id)
|
||||
if (inProgressSessions.length === 0) return null
|
||||
|
||||
const batchId = inProgressSessions[0].batch_id!
|
||||
|
||||
// Count all sessions in this batch
|
||||
const batchSessions = sessions.filter(s => s.batch_id === batchId)
|
||||
const completed = batchSessions.filter(s => s.completed_at).length
|
||||
const total = batchSessions.length
|
||||
|
||||
return (
|
||||
<div className="flex items-center gap-3 rounded-xl border border-amber-500/30 bg-amber-500/5 px-4 py-3">
|
||||
<RefreshCw className="h-4 w-4 shrink-0 animate-spin text-amber-400" />
|
||||
<p className="flex-1 text-[0.875rem] text-amber-300">
|
||||
Batch in progress · <span className="font-medium">{completed} of {total}</span> targets complete
|
||||
</p>
|
||||
<button
|
||||
onClick={() => navigate(`/flows/${treeId}/batches/${batchId}`)}
|
||||
className="flex items-center gap-1 text-[0.8125rem] font-medium text-amber-400 hover:text-amber-300 transition-colors"
|
||||
>
|
||||
View Batch
|
||||
<ChevronRight className="h-3.5 w-3.5" />
|
||||
</button>
|
||||
<button
|
||||
onClick={onDismiss}
|
||||
className="rounded-md p-1 text-muted-foreground hover:bg-accent hover:text-foreground transition-colors"
|
||||
>
|
||||
<X className="h-3.5 w-3.5" />
|
||||
</button>
|
||||
</div>
|
||||
)
|
||||
}
|
||||
144
frontend/src/components/maintenance/BatchStatusCard.tsx
Normal file
144
frontend/src/components/maintenance/BatchStatusCard.tsx
Normal file
@@ -0,0 +1,144 @@
|
||||
import { CheckCircle, Circle, Loader2, Play, RotateCcw, Eye } from 'lucide-react'
|
||||
import { useNavigate } from 'react-router-dom'
|
||||
import { cn } from '@/lib/utils'
|
||||
import type { Session } from '@/types'
|
||||
|
||||
interface BatchStatusCardProps {
|
||||
session: Session | null
|
||||
targetLabel: string
|
||||
treeId: string
|
||||
batchId: string
|
||||
}
|
||||
|
||||
function formatDuration(startedAt: string, completedAt: string): string {
|
||||
const ms = new Date(completedAt).getTime() - new Date(startedAt).getTime()
|
||||
const totalSeconds = Math.floor(ms / 1000)
|
||||
const minutes = Math.floor(totalSeconds / 60)
|
||||
const seconds = totalSeconds % 60
|
||||
if (minutes === 0) return `${seconds}s`
|
||||
return `${minutes}m ${seconds}s`
|
||||
}
|
||||
|
||||
const OUTCOME_LABELS: Record<string, string> = {
|
||||
resolved: 'Resolved',
|
||||
escalated: 'Escalated',
|
||||
workaround: 'Workaround',
|
||||
unresolved: 'Unresolved',
|
||||
}
|
||||
|
||||
const OUTCOME_COLORS: Record<string, string> = {
|
||||
resolved: 'text-emerald-400 bg-emerald-500/10',
|
||||
escalated: 'text-red-400 bg-red-500/10',
|
||||
workaround: 'text-amber-400 bg-amber-500/10',
|
||||
unresolved: 'text-muted-foreground bg-muted',
|
||||
}
|
||||
|
||||
export function BatchStatusCard({ session, targetLabel, treeId, batchId }: BatchStatusCardProps) {
|
||||
const navigate = useNavigate()
|
||||
|
||||
const isComplete = !!session?.completed_at
|
||||
const isInProgress = !!session?.started_at && !session.completed_at
|
||||
const isNotStarted = !session || !session.started_at
|
||||
|
||||
// Derive step progress for in-progress sessions
|
||||
const stepProgress = (() => {
|
||||
if (!session || !isInProgress) return null
|
||||
const snapshot = session.tree_snapshot as { steps?: { type: string }[] } | null
|
||||
const totalSteps = snapshot?.steps?.filter(s => s.type === 'procedure_step').length ?? 0
|
||||
const completedSteps = (session.decisions ?? []).filter(d => d.answer === 'completed').length
|
||||
return totalSteps > 0 ? { completed: completedSteps, total: totalSteps } : null
|
||||
})()
|
||||
|
||||
const handleStart = () => {
|
||||
navigate(`/flows/${treeId}/navigate`, {
|
||||
state: { targetLabel, batchId },
|
||||
})
|
||||
}
|
||||
|
||||
const handleResume = () => {
|
||||
if (!session) return
|
||||
navigate(`/flows/${treeId}/navigate`, {
|
||||
state: { sessionId: session.id },
|
||||
})
|
||||
}
|
||||
|
||||
const handleView = () => {
|
||||
if (!session) return
|
||||
navigate(`/sessions/${session.id}`)
|
||||
}
|
||||
|
||||
return (
|
||||
<div className="flex items-center justify-between rounded-lg border border-border bg-card px-4 py-3 gap-4">
|
||||
{/* Status indicator + target name */}
|
||||
<div className="flex items-center gap-3 min-w-0">
|
||||
{isComplete && (
|
||||
<CheckCircle className="h-4 w-4 shrink-0 text-emerald-400" />
|
||||
)}
|
||||
{isInProgress && (
|
||||
<Loader2 className="h-4 w-4 shrink-0 text-amber-400 animate-spin" />
|
||||
)}
|
||||
{isNotStarted && (
|
||||
<Circle className="h-4 w-4 shrink-0 text-muted-foreground" />
|
||||
)}
|
||||
|
||||
<div className="min-w-0">
|
||||
<p className="text-[0.875rem] font-medium text-foreground truncate">{targetLabel}</p>
|
||||
<div className="flex items-center gap-2 mt-0.5">
|
||||
{isComplete && session?.outcome && (
|
||||
<span className={cn(
|
||||
"font-label text-[0.625rem] uppercase tracking-wide rounded-full px-2 py-0.5",
|
||||
OUTCOME_COLORS[session.outcome] ?? OUTCOME_COLORS.unresolved
|
||||
)}>
|
||||
{OUTCOME_LABELS[session.outcome] ?? session.outcome}
|
||||
</span>
|
||||
)}
|
||||
{isComplete && session?.started_at && session?.completed_at && (
|
||||
<span className="text-[0.75rem] text-muted-foreground">
|
||||
{formatDuration(session.started_at, session.completed_at)}
|
||||
</span>
|
||||
)}
|
||||
{isInProgress && stepProgress && (
|
||||
<span className="text-[0.75rem] text-amber-400">
|
||||
Step {stepProgress.completed + 1} of {stepProgress.total}
|
||||
</span>
|
||||
)}
|
||||
{isNotStarted && (
|
||||
<span className="text-[0.75rem] text-muted-foreground">Not started</span>
|
||||
)}
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
{/* Action button */}
|
||||
<div className="shrink-0">
|
||||
{isComplete && (
|
||||
<button
|
||||
onClick={handleView}
|
||||
className="flex items-center gap-1.5 rounded-lg border border-border px-3 py-1.5 text-[0.8125rem] text-muted-foreground hover:bg-accent hover:text-foreground transition-colors"
|
||||
>
|
||||
<Eye className="h-3.5 w-3.5" />
|
||||
View
|
||||
</button>
|
||||
)}
|
||||
{isInProgress && (
|
||||
<button
|
||||
onClick={handleResume}
|
||||
className="flex items-center gap-1.5 rounded-lg bg-amber-500/10 border border-amber-500/30 px-3 py-1.5 text-[0.8125rem] text-amber-400 hover:bg-amber-500/20 transition-colors"
|
||||
>
|
||||
<RotateCcw className="h-3.5 w-3.5" />
|
||||
Resume
|
||||
</button>
|
||||
)}
|
||||
{isNotStarted && (
|
||||
<button
|
||||
onClick={handleStart}
|
||||
className="flex items-center gap-1.5 rounded-lg bg-gradient-brand px-3 py-1.5 text-[0.8125rem] font-medium text-white shadow-sm shadow-primary/20 hover:opacity-90 transition-opacity"
|
||||
>
|
||||
<Play className="h-3.5 w-3.5" />
|
||||
Start
|
||||
</button>
|
||||
)}
|
||||
</div>
|
||||
</div>
|
||||
)
|
||||
}
|
||||
@@ -0,0 +1,46 @@
|
||||
import { Wrench, ChevronLeft } from 'lucide-react'
|
||||
import { useNavigate } from 'react-router-dom'
|
||||
|
||||
interface MaintenanceContextStripProps {
|
||||
treeId: string
|
||||
targetLabel?: string | null
|
||||
batchId?: string | null
|
||||
batchProgress?: { completed: number; total: number } | null
|
||||
}
|
||||
|
||||
export function MaintenanceContextStrip({
|
||||
treeId,
|
||||
targetLabel,
|
||||
batchId,
|
||||
batchProgress,
|
||||
}: MaintenanceContextStripProps) {
|
||||
const navigate = useNavigate()
|
||||
|
||||
return (
|
||||
<div className="flex items-center gap-3 border-b border-amber-500/20 bg-amber-500/5 px-4 py-2 text-sm">
|
||||
<Wrench className="h-3.5 w-3.5 shrink-0 text-amber-400" />
|
||||
<span className="font-medium text-amber-300">
|
||||
{targetLabel ? `Target: ${targetLabel}` : 'Manual Run'}
|
||||
</span>
|
||||
|
||||
{batchProgress && (
|
||||
<>
|
||||
<span className="text-muted-foreground">·</span>
|
||||
<span className="text-muted-foreground text-[0.8125rem]">
|
||||
{batchProgress.completed} / {batchProgress.total} complete
|
||||
</span>
|
||||
</>
|
||||
)}
|
||||
|
||||
{batchId && (
|
||||
<button
|
||||
onClick={() => navigate(`/flows/${treeId}/batches/${batchId}`)}
|
||||
className="ml-auto flex items-center gap-1 text-xs text-amber-400 hover:text-amber-300 transition-colors"
|
||||
>
|
||||
<ChevronLeft className="h-3 w-3" />
|
||||
Back to Batch
|
||||
</button>
|
||||
)}
|
||||
</div>
|
||||
)
|
||||
}
|
||||
Reference in New Issue
Block a user