fix: 6 integration audit fixes — ticket filter, admin nav, FK scope, debounce, error messages

- Fix AISession.ticket_id → psa_ticket_id in list_sessions filter query
- Add Gallery nav item (LayoutGrid icon) to AdminSidebar navItems array
- Remove ForeignKey from FileUpload.session_id (Python model) + migration b8d2f4a6c091 to drop DB constraint, allowing column to reference either session type
- Add 400ms debounce on AI session search input in SessionHistoryPage (aiSearchInput state + useRef timeout pattern)
- Show friendly 503 error message in RichTextInput upload error handler (both initial upload and retry paths)
- Add overflow-x-auto to FlowPilotAnalyticsPage tab bar container

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-03-20 04:06:41 +00:00
parent cb54045593
commit 2ed8a2af15
7 changed files with 70 additions and 11 deletions

View File

@@ -0,0 +1,34 @@
"""drop file_uploads session_id foreign key constraint
Revision ID: b8d2f4a6c091
Revises: a7c9e3b1f402
Create Date: 2026-03-20 00:00:00.000000
The session_id column on file_uploads previously referenced ai_sessions.id.
Removing the FK allows the column to reference either AI sessions or regular
sessions without a constraint violation, while keeping the index for query
performance.
"""
from typing import Sequence, Union
from alembic import op
# revision identifiers, used by Alembic.
revision: str = 'b8d2f4a6c091'
down_revision: Union[str, None] = 'a7c9e3b1f402'
branch_labels: Union[str, Sequence[str], None] = None
depends_on: Union[str, Sequence[str], None] = None
def upgrade() -> None:
op.drop_constraint('file_uploads_session_id_fkey', 'file_uploads', type_='foreignkey')
def downgrade() -> None:
op.create_foreign_key(
'file_uploads_session_id_fkey',
'file_uploads', 'ai_sessions',
['session_id'], ['id'],
ondelete='SET NULL',
)

View File

@@ -562,7 +562,7 @@ async def list_sessions(
if confidence_tier: if confidence_tier:
query = query.where(AISession.confidence_tier == confidence_tier) query = query.where(AISession.confidence_tier == confidence_tier)
if ticket_id: if ticket_id:
query = query.where(AISession.ticket_id == ticket_id) query = query.where(AISession.psa_ticket_id == ticket_id)
if date_from: if date_from:
query = query.where(AISession.created_at >= date_from) query = query.where(AISession.created_at >= date_from)
if date_to: if date_to:

View File

@@ -21,7 +21,7 @@ class FileUpload(Base):
UUID(as_uuid=True), ForeignKey("users.id", ondelete="SET NULL"), nullable=False UUID(as_uuid=True), ForeignKey("users.id", ondelete="SET NULL"), nullable=False
) )
session_id: Mapped[Optional[uuid.UUID]] = mapped_column( session_id: Mapped[Optional[uuid.UUID]] = mapped_column(
UUID(as_uuid=True), ForeignKey("ai_sessions.id", ondelete="SET NULL"), nullable=True, index=True UUID(as_uuid=True), nullable=True, index=True
) )
filename: Mapped[str] = mapped_column(String(255), nullable=False) filename: Mapped[str] = mapped_column(String(255), nullable=False)
content_type: Mapped[str] = mapped_column(String(100), nullable=False) content_type: Mapped[str] = mapped_column(String(100), nullable=False)

View File

@@ -10,6 +10,7 @@ import {
FolderTree, FolderTree,
ClipboardList, ClipboardList,
MessageSquareText, MessageSquareText,
LayoutGrid,
ArrowLeft, ArrowLeft,
} from 'lucide-react' } from 'lucide-react'
import { cn } from '@/lib/utils' import { cn } from '@/lib/utils'
@@ -25,6 +26,7 @@ const navItems = [
{ path: '/admin/categories', label: 'Categories', icon: FolderTree }, { path: '/admin/categories', label: 'Categories', icon: FolderTree },
{ path: '/admin/survey-invites', label: 'Survey Invites', icon: ClipboardList }, { path: '/admin/survey-invites', label: 'Survey Invites', icon: ClipboardList },
{ path: '/admin/survey-responses', label: 'Survey Responses', icon: MessageSquareText }, { path: '/admin/survey-responses', label: 'Survey Responses', icon: MessageSquareText },
{ path: '/admin/gallery', label: 'Gallery', icon: LayoutGrid },
] ]
interface AdminSidebarProps { interface AdminSidebarProps {

View File

@@ -73,10 +73,13 @@ export function RichTextInput({
}) })
}) })
.catch((err) => { .catch((err) => {
const errorMsg = err?.response?.status === 503
? 'File uploads not available — contact your administrator'
: err?.message || 'Upload failed'
setPendingUploads((prev) => setPendingUploads((prev) =>
prev.map((u) => prev.map((u) =>
u.id === upload.id u.id === upload.id
? { ...u, status: 'error' as const, error: err?.message || 'Upload failed' } ? { ...u, status: 'error' as const, error: errorMsg }
: u : u
) )
) )
@@ -196,10 +199,13 @@ export function RichTextInput({
}) })
}) })
.catch((err) => { .catch((err) => {
const errorMsg = err?.response?.status === 503
? 'File uploads not available — contact your administrator'
: err?.message || 'Upload failed'
setPendingUploads((prev) => setPendingUploads((prev) =>
prev.map((u) => prev.map((u) =>
u.id === uploadId u.id === uploadId
? { ...u, status: 'error' as const, error: err?.message || 'Upload failed' } ? { ...u, status: 'error' as const, error: errorMsg }
: u : u
) )
) )

View File

@@ -189,7 +189,7 @@ export default function FlowPilotAnalyticsPage() {
</div> </div>
{/* Tab bar */} {/* Tab bar */}
<div className="flex gap-1 border-b border-border"> <div className="flex gap-1 border-b border-border overflow-x-auto">
{TABS.map((tab) => ( {TABS.map((tab) => (
<button <button
key={tab.id} key={tab.id}

View File

@@ -25,6 +25,8 @@ export function SessionHistoryPage() {
const [sessionType, setSessionType] = useState<'flow' | 'ai'>('flow') const [sessionType, setSessionType] = useState<'flow' | 'ai'>('flow')
const [aiSessions, setAiSessions] = useState<AISessionSummary[]>([]) const [aiSessions, setAiSessions] = useState<AISessionSummary[]>([])
const [aiLoading, setAiLoading] = useState(false) const [aiLoading, setAiLoading] = useState(false)
const [aiSearchInput, setAiSearchInput] = useState('')
const aiSearchTimeout = useRef<ReturnType<typeof setTimeout> | undefined>(undefined)
const [aiFilters, setAiFilters] = useState({ const [aiFilters, setAiFilters] = useState({
q: '', q: '',
problem_domain: '', problem_domain: '',
@@ -67,6 +69,15 @@ export function SessionHistoryPage() {
} }
}) })
// Debounce AI search input → aiFilters.q
useEffect(() => {
if (aiSearchTimeout.current) clearTimeout(aiSearchTimeout.current)
aiSearchTimeout.current = setTimeout(() => {
setAiFilters(prev => ({ ...prev, q: aiSearchInput }))
}, 400)
return () => { if (aiSearchTimeout.current) clearTimeout(aiSearchTimeout.current) }
}, [aiSearchInput])
// Load trees for filter dropdown // Load trees for filter dropdown
useEffect(() => { useEffect(() => {
const loadTrees = async () => { const loadTrees = async () => {
@@ -324,8 +335,8 @@ export function SessionHistoryPage() {
<Search className="absolute left-2.5 top-1/2 -translate-y-1/2 h-3.5 w-3.5 text-muted-foreground pointer-events-none" /> <Search className="absolute left-2.5 top-1/2 -translate-y-1/2 h-3.5 w-3.5 text-muted-foreground pointer-events-none" />
<input <input
type="text" type="text"
value={aiFilters.q} value={aiSearchInput}
onChange={(e) => setAiFilters((f) => ({ ...f, q: e.target.value }))} onChange={(e) => setAiSearchInput(e.target.value)}
placeholder="Search sessions..." placeholder="Search sessions..."
className="w-full rounded-lg border border-border bg-card pl-8 pr-3 py-1.5 text-sm text-foreground placeholder:text-muted-foreground focus:border-[rgba(6,182,212,0.3)] focus:outline-none" className="w-full rounded-lg border border-border bg-card pl-8 pr-3 py-1.5 text-sm text-foreground placeholder:text-muted-foreground focus:border-[rgba(6,182,212,0.3)] focus:outline-none"
/> />
@@ -389,9 +400,12 @@ export function SessionHistoryPage() {
</div> </div>
{/* Clear filters */} {/* Clear filters */}
{(aiFilters.q || aiFilters.problem_domain || aiFilters.confidence_tier || aiFilters.date_from || aiFilters.date_to) && ( {(aiSearchInput || aiFilters.q || aiFilters.problem_domain || aiFilters.confidence_tier || aiFilters.date_from || aiFilters.date_to) && (
<button <button
onClick={() => setAiFilters({ q: '', problem_domain: '', confidence_tier: '', date_from: '', date_to: '' })} onClick={() => {
setAiSearchInput('')
setAiFilters({ q: '', problem_domain: '', confidence_tier: '', date_from: '', date_to: '' })
}}
className="text-xs text-muted-foreground hover:text-foreground transition-colors" className="text-xs text-muted-foreground hover:text-foreground transition-colors"
> >
Clear Clear
@@ -405,13 +419,16 @@ export function SessionHistoryPage() {
<Spinner /> <Spinner />
</div> </div>
) : aiSessions.length === 0 ? ( ) : aiSessions.length === 0 ? (
(aiFilters.q || aiFilters.problem_domain || aiFilters.confidence_tier || aiFilters.date_from || aiFilters.date_to) ? ( (aiSearchInput || aiFilters.q || aiFilters.problem_domain || aiFilters.confidence_tier || aiFilters.date_from || aiFilters.date_to) ? (
<EmptyState <EmptyState
title="No sessions match your filters" title="No sessions match your filters"
description="Try adjusting your search or filters." description="Try adjusting your search or filters."
action={ action={
<button <button
onClick={() => setAiFilters({ q: '', problem_domain: '', confidence_tier: '', date_from: '', date_to: '' })} onClick={() => {
setAiSearchInput('')
setAiFilters({ q: '', problem_domain: '', confidence_tier: '', date_from: '', date_to: '' })
}}
className="text-foreground hover:underline text-sm" className="text-foreground hover:underline text-sm"
> >
Clear all filters Clear all filters