e05472615b
P3-A: Add account_id to audit_logs model + migration (backfill via user_id → users.account_id). log_audit() gains optional account_id param with fallback SELECT to avoid churn across 40 call sites. P3-B: Add account_id to tree_shares model + migration (backfill via created_by → users.account_id). TreeShare constructor updated in trees.py. P3-C: Enable RLS on 6 remaining tables: step_ratings, step_usage_log, target_lists, session_shares, audit_logs, tree_shares. P3-D: Drop team_id from target_lists — endpoint, schema, and model now use account_id as the sole isolation key. P3-E: Append Phase 3 RLS isolation tests for all 6 tables. test_target_lists.py: fix cross-account test to use Account model (not Team) and set account_id on new User. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
52 lines
1.7 KiB
Python
52 lines
1.7 KiB
Python
"""Add account_id to tree_shares and backfill via created_by user.
|
|
|
|
Revision ID: a05e1a1bea7c
|
|
Revises: 2a9056eddd90
|
|
Create Date: 2026-04-11 00:00:00.000000
|
|
"""
|
|
from typing import Sequence, Union
|
|
from alembic import op
|
|
import sqlalchemy as sa
|
|
|
|
revision: str = 'a05e1a1bea7c'
|
|
down_revision: Union[str, None] = '2a9056eddd90'
|
|
branch_labels: Union[str, Sequence[str], None] = None
|
|
depends_on: Union[str, Sequence[str], None] = None
|
|
|
|
|
|
def upgrade() -> None:
|
|
op.add_column('tree_shares', sa.Column('account_id', sa.UUID(), nullable=True))
|
|
op.create_foreign_key(
|
|
'fk_tree_shares_account_id', 'tree_shares', 'accounts',
|
|
['account_id'], ['id'], ondelete='CASCADE',
|
|
)
|
|
|
|
# Backfill: derive from the creating user's account
|
|
op.execute("""
|
|
UPDATE tree_shares ts
|
|
SET account_id = u.account_id
|
|
FROM users u
|
|
WHERE ts.created_by = u.id
|
|
AND u.account_id IS NOT NULL
|
|
AND ts.account_id IS NULL
|
|
""")
|
|
|
|
result = op.get_bind().execute(
|
|
sa.text("SELECT COUNT(*) FROM tree_shares WHERE account_id IS NULL")
|
|
)
|
|
count = result.scalar()
|
|
if count > 0:
|
|
raise RuntimeError(
|
|
f"ROLLBACK: {count} tree_shares rows have NULL account_id after backfill. "
|
|
"All share entries must have a creating user with an account."
|
|
)
|
|
|
|
op.alter_column('tree_shares', 'account_id', nullable=False)
|
|
op.create_index('ix_tree_shares_account_id', 'tree_shares', ['account_id'])
|
|
|
|
|
|
def downgrade() -> None:
|
|
op.drop_index('ix_tree_shares_account_id', table_name='tree_shares')
|
|
op.drop_constraint('fk_tree_shares_account_id', 'tree_shares', type_='foreignkey')
|
|
op.drop_column('tree_shares', 'account_id')
|