chihlasm
0f750e63e0
Full notification infrastructure with in-app, email, Slack, and Teams channels: Backend: - NotificationConfig, NotificationLog, Notification models + migration - Notification service with event routing, channel delivery, retry logic - 9 API endpoints (config CRUD + in-app notifications) - APScheduler retry job with exponential backoff (30s, 2m, 10m) - Wired into escalation, proposal approval, and knowledge flywheel - Pydantic event key validation, cross-tenant protection on recipients Frontend: - TypeScript types + API client for all notification endpoints - NotificationsPanel: bell icon with unread badge, dropdown, mark-read - NotificationSettings: channel config, event toggles, test, delete confirm - Notifications tab on IntegrationsPage - ARIA attributes, Escape handler, settings link on panel Review fixes (13 issues resolved): - notify() no longer commits/rolls back caller's transaction (critical) - retry_failed_notifications returns count instead of None (critical) - NotificationSettings moved inside dedicated tab (critical) - target_user_ids scoped by account_id (security) - Email loop collects all failures before raising - Slack webhook validates response body - events_enabled rejects unknown event keys - link column widened to String(500) - Dead code removed from _auto_reinforce - Delete confirmation, ARIA, Escape key support Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
84 lines
4.3 KiB
Python
84 lines
4.3 KiB
Python
"""add notification tables
|
|
|
|
Revision ID: b09c3789b7e6
|
|
Revises: 3266dd9d8111
|
|
Create Date: 2026-03-19 06:16:46.817718
|
|
|
|
"""
|
|
from typing import Sequence, Union
|
|
|
|
from alembic import op
|
|
import sqlalchemy as sa
|
|
from sqlalchemy.dialects import postgresql
|
|
|
|
# revision identifiers, used by Alembic.
|
|
revision: str = 'b09c3789b7e6'
|
|
down_revision: Union[str, None] = '3266dd9d8111'
|
|
branch_labels: Union[str, Sequence[str], None] = None
|
|
depends_on: Union[str, Sequence[str], None] = None
|
|
|
|
|
|
def upgrade() -> None:
|
|
op.create_table('notification_configs',
|
|
sa.Column('id', sa.UUID(), nullable=False),
|
|
sa.Column('account_id', sa.UUID(), nullable=False),
|
|
sa.Column('channel', sa.String(length=20), nullable=False),
|
|
sa.Column('webhook_url', sa.String(length=500), nullable=True),
|
|
sa.Column('email_addresses', postgresql.JSONB(astext_type=sa.Text()), nullable=True),
|
|
sa.Column('is_active', sa.Boolean(), nullable=False),
|
|
sa.Column('events_enabled', postgresql.JSONB(astext_type=sa.Text()), nullable=False),
|
|
sa.Column('created_at', sa.DateTime(timezone=True), nullable=False),
|
|
sa.Column('updated_at', sa.DateTime(timezone=True), nullable=False),
|
|
sa.CheckConstraint("channel IN ('email', 'slack_webhook', 'teams_webhook')", name='ck_notification_configs_channel'),
|
|
sa.ForeignKeyConstraint(['account_id'], ['accounts.id'], ondelete='CASCADE'),
|
|
sa.PrimaryKeyConstraint('id')
|
|
)
|
|
op.create_index(op.f('ix_notification_configs_account_id'), 'notification_configs', ['account_id'], unique=False)
|
|
|
|
op.create_table('notifications',
|
|
sa.Column('id', sa.UUID(), nullable=False),
|
|
sa.Column('account_id', sa.UUID(), nullable=False),
|
|
sa.Column('user_id', sa.UUID(), nullable=False),
|
|
sa.Column('event', sa.String(length=50), nullable=False),
|
|
sa.Column('title', sa.String(length=200), nullable=False),
|
|
sa.Column('body', sa.String(length=500), nullable=True),
|
|
sa.Column('link', sa.String(length=500), nullable=True),
|
|
sa.Column('is_read', sa.Boolean(), nullable=False),
|
|
sa.Column('created_at', sa.DateTime(timezone=True), nullable=False),
|
|
sa.ForeignKeyConstraint(['account_id'], ['accounts.id'], ondelete='CASCADE'),
|
|
sa.ForeignKeyConstraint(['user_id'], ['users.id'], ondelete='CASCADE'),
|
|
sa.PrimaryKeyConstraint('id')
|
|
)
|
|
op.create_index(op.f('ix_notifications_account_id'), 'notifications', ['account_id'], unique=False)
|
|
op.create_index(op.f('ix_notifications_created_at'), 'notifications', ['created_at'], unique=False)
|
|
op.create_index(op.f('ix_notifications_user_id'), 'notifications', ['user_id'], unique=False)
|
|
|
|
op.create_table('notification_logs',
|
|
sa.Column('id', sa.UUID(), nullable=False),
|
|
sa.Column('notification_config_id', sa.UUID(), nullable=False),
|
|
sa.Column('event', sa.String(length=50), nullable=False),
|
|
sa.Column('payload', postgresql.JSONB(astext_type=sa.Text()), nullable=False),
|
|
sa.Column('status', sa.String(length=20), nullable=False),
|
|
sa.Column('retry_count', sa.Integer(), nullable=False),
|
|
sa.Column('max_retries', sa.Integer(), nullable=False),
|
|
sa.Column('last_error', sa.String(length=1000), nullable=True),
|
|
sa.Column('next_retry_at', sa.DateTime(timezone=True), nullable=True),
|
|
sa.Column('created_at', sa.DateTime(timezone=True), nullable=False),
|
|
sa.Column('delivered_at', sa.DateTime(timezone=True), nullable=True),
|
|
sa.CheckConstraint("status IN ('sent', 'failed', 'retrying', 'exhausted')", name='ck_notification_logs_status'),
|
|
sa.ForeignKeyConstraint(['notification_config_id'], ['notification_configs.id'], ondelete='CASCADE'),
|
|
sa.PrimaryKeyConstraint('id')
|
|
)
|
|
op.create_index(op.f('ix_notification_logs_notification_config_id'), 'notification_logs', ['notification_config_id'], unique=False)
|
|
|
|
|
|
def downgrade() -> None:
|
|
op.drop_index(op.f('ix_notification_logs_notification_config_id'), table_name='notification_logs')
|
|
op.drop_table('notification_logs')
|
|
op.drop_index(op.f('ix_notifications_user_id'), table_name='notifications')
|
|
op.drop_index(op.f('ix_notifications_created_at'), table_name='notifications')
|
|
op.drop_index(op.f('ix_notifications_account_id'), table_name='notifications')
|
|
op.drop_table('notifications')
|
|
op.drop_index(op.f('ix_notification_configs_account_id'), table_name='notification_configs')
|
|
op.drop_table('notification_configs')
|