Michael Chihlas
87bd0b7c56
First half of the WebSocket/SSE push slice. Paused mid-flight to hand
the branch to Codex for outside-voice review before stacking more
commits on top. See .ai/HANDOFF.md for the full pause context + what
to look at.
What's here:
- backend/app/core/escalation_bus.py — module-level singleton in-memory
pub/sub keyed by account_id. asyncio.Queue per subscriber with
64-event maxsize and drop-on-full semantics. Designed to be swappable
for Redis pub/sub when Railway scales past single-replica.
- backend/app/api/endpoints/session_handoffs.py — GET
/api/v1/ai-sessions/escalations/stream SSE endpoint. Auth via
require_engineer_or_admin. 25s heartbeat. Account-scoped subscribe
bound to current_user.account_id.
- backend/app/services/handoff_manager.py — dispatch_escalation_notifications
now publishes a `handoff_created` event to the bus BEFORE the email
fan-out, in a try/except so a bus failure can't block email delivery.
- backend/tests/test_escalation_bus.py — 7 unit tests, all green
standalone (0.14s). Cross-tenant isolation, drop-on-full, no-subscribers.
- backend/tests/test_handoff_manager.py — +1 dispatcher integration test
(publishes to bus, payload shape).
- backend/tests/test_session_handoffs_api.py — +2 endpoint tests (viewer
blocked, ready event handshake).
[gstack-context]
Decisions:
- SSE over WebSocket (one-way, browser EventSource semantics, fewer
moving parts behind Railway proxy)
- In-memory bus over Redis for v1 pilot (3 MSPs, single replica)
- Drop-on-full subscriber queue rather than back-pressure publishers
- Bus publish ahead of email send, both wrapped in try/except so
neither can break handoff creation
- Frontend will be a fetch-based ReadableStream reader matching the
existing streamDocumentation pattern, not native EventSource
(custom-header auth)
Remaining (post-Codex):
- Frontend SSE subscription in EscalationQueue.tsx (slide-in,
reconnect, tab-title flash, prefers-reduced-motion)
- Magic-moment handoff-context screen
- Re-run the full backend test suite to verify the SSE +
dispatcher integration tests (bus units already green standalone)
Tried:
- Running the full test suite repeatedly without xdist; the per-test
DROP SCHEMA + recreate fixture made wall-clock prohibitive when
multiple stale runs collided on the same Postgres test schema.
Resolution: -n auto next time.
[/gstack-context]
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
376 lines
12 KiB
Python
376 lines
12 KiB
Python
"""Integration tests for HandoffManager service."""
|
|
from unittest.mock import AsyncMock, patch
|
|
|
|
import pytest
|
|
from httpx import AsyncClient
|
|
|
|
from app.models.ai_session import AISession
|
|
from app.models.user import User
|
|
from app.services.handoff_manager import HandoffManager
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_create_park_handoff(client: AsyncClient, test_user, auth_headers, test_db):
|
|
"""Parking a session creates a handoff with snapshot."""
|
|
session = AISession(
|
|
user_id=test_user["user_data"]["id"],
|
|
account_id=test_user["user_data"]["account_id"],
|
|
session_type="guided",
|
|
intake_type="free_text",
|
|
intake_content={"text": "test"},
|
|
status="active",
|
|
confidence_tier="discovery",
|
|
conversation_messages=[{"role": "user", "content": "help me"}],
|
|
)
|
|
test_db.add(session)
|
|
await test_db.flush()
|
|
|
|
from app.services.handoff_manager import HandoffManager
|
|
manager = HandoffManager(test_db)
|
|
|
|
handoff = await manager.create_handoff(
|
|
session_id=session.id,
|
|
intent="park",
|
|
engineer_notes="Waiting for client to provide logs",
|
|
user_id=test_user["user_data"]["id"],
|
|
)
|
|
|
|
assert handoff is not None
|
|
assert handoff.intent == "park"
|
|
assert handoff.engineer_notes == "Waiting for client to provide logs"
|
|
assert handoff.snapshot is not None
|
|
|
|
# Session should be paused
|
|
await test_db.refresh(session)
|
|
assert session.status == "paused"
|
|
assert session.handoff_count == 1
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_create_escalate_handoff(client: AsyncClient, test_user, auth_headers, test_db):
|
|
"""Escalating creates handoff + dual-writes to escalation_package."""
|
|
session = AISession(
|
|
user_id=test_user["user_data"]["id"],
|
|
account_id=test_user["user_data"]["account_id"],
|
|
session_type="guided",
|
|
intake_type="free_text",
|
|
intake_content={"text": "test"},
|
|
status="active",
|
|
confidence_tier="discovery",
|
|
conversation_messages=[],
|
|
)
|
|
test_db.add(session)
|
|
await test_db.flush()
|
|
|
|
from app.services.handoff_manager import HandoffManager
|
|
manager = HandoffManager(test_db)
|
|
|
|
handoff = await manager.create_handoff(
|
|
session_id=session.id,
|
|
intent="escalate",
|
|
engineer_notes="Need senior help",
|
|
user_id=test_user["user_data"]["id"],
|
|
)
|
|
|
|
assert handoff.intent == "escalate"
|
|
|
|
# Dual-write check
|
|
await test_db.refresh(session)
|
|
assert session.status == "escalated"
|
|
assert session.escalation_package is not None
|
|
assert "branch_map" in session.escalation_package or "snapshot" in session.escalation_package
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_claim_session(client: AsyncClient, test_user, test_admin, auth_headers, test_db):
|
|
"""Claiming a handoff sets claimed_by and reactivates session."""
|
|
session = AISession(
|
|
user_id=test_user["user_data"]["id"],
|
|
account_id=test_user["user_data"]["account_id"],
|
|
session_type="guided",
|
|
intake_type="free_text",
|
|
intake_content={"text": "test"},
|
|
status="active",
|
|
confidence_tier="discovery",
|
|
conversation_messages=[],
|
|
)
|
|
test_db.add(session)
|
|
await test_db.flush()
|
|
|
|
from app.services.handoff_manager import HandoffManager
|
|
manager = HandoffManager(test_db)
|
|
|
|
handoff = await manager.create_handoff(
|
|
session_id=session.id,
|
|
intent="escalate",
|
|
engineer_notes="Need help",
|
|
user_id=test_user["user_data"]["id"],
|
|
)
|
|
|
|
claimed = await manager.claim_session(
|
|
handoff_id=handoff.id,
|
|
claiming_user_id=test_admin["user_data"]["id"],
|
|
)
|
|
|
|
assert claimed.claimed_by == test_admin["user_data"]["id"]
|
|
assert claimed.claimed_at is not None
|
|
|
|
await test_db.refresh(session)
|
|
assert session.status == "active"
|
|
|
|
|
|
# ─── Notification dispatch ────────────────────────────────────────────────────
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_dispatch_emails_engineer_recipients_in_account(
|
|
client: AsyncClient, test_user, auth_headers, test_db
|
|
):
|
|
"""dispatch_escalation_notifications emails every engineer/admin in the
|
|
account except the escalator."""
|
|
# Add a second user (engineer role) in the same account.
|
|
teammate = User(
|
|
email="teammate@example.com",
|
|
password_hash="x",
|
|
name="Teammate",
|
|
role="engineer",
|
|
account_id=test_user["user_data"]["account_id"],
|
|
account_role="engineer",
|
|
)
|
|
test_db.add(teammate)
|
|
await test_db.flush()
|
|
|
|
# Add a viewer-role user — must NOT receive a notification.
|
|
viewer = User(
|
|
email="viewer@example.com",
|
|
password_hash="x",
|
|
name="Viewer",
|
|
role="engineer",
|
|
account_id=test_user["user_data"]["account_id"],
|
|
account_role="viewer",
|
|
)
|
|
test_db.add(viewer)
|
|
await test_db.flush()
|
|
|
|
session = AISession(
|
|
user_id=test_user["user_data"]["id"],
|
|
account_id=test_user["user_data"]["account_id"],
|
|
session_type="guided",
|
|
intake_type="free_text",
|
|
intake_content={"text": "vpn down"},
|
|
problem_summary="VPN won't connect after Win update",
|
|
status="active",
|
|
confidence_tier="discovery",
|
|
conversation_messages=[],
|
|
)
|
|
test_db.add(session)
|
|
await test_db.commit()
|
|
|
|
manager = HandoffManager(test_db)
|
|
handoff = await manager.create_handoff(
|
|
session_id=session.id,
|
|
intent="escalate",
|
|
engineer_notes="Stuck on auth handshake",
|
|
user_id=test_user["user_data"]["id"],
|
|
)
|
|
await test_db.commit()
|
|
|
|
with patch(
|
|
"app.services.handoff_manager.EmailService.send_notification_email",
|
|
new=AsyncMock(return_value=True),
|
|
) as send:
|
|
sent = await manager.dispatch_escalation_notifications(handoff)
|
|
|
|
assert sent == 1 # only the engineer-role teammate
|
|
recipients = {call.kwargs["to_email"] for call in send.call_args_list}
|
|
assert recipients == {"teammate@example.com"}
|
|
assert viewer.email not in recipients
|
|
assert test_user["email"] not in recipients # not self-notified
|
|
|
|
title = send.call_args_list[0].kwargs["title"]
|
|
assert "VPN won't connect after Win update" in title
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_dispatch_skipped_for_park_intent(
|
|
client: AsyncClient, test_user, auth_headers, test_db
|
|
):
|
|
"""park-intent handoffs are private (waiting for client logs etc) — no
|
|
team-wide email."""
|
|
session = AISession(
|
|
user_id=test_user["user_data"]["id"],
|
|
account_id=test_user["user_data"]["account_id"],
|
|
session_type="guided",
|
|
intake_type="free_text",
|
|
intake_content={"text": "x"},
|
|
status="active",
|
|
confidence_tier="discovery",
|
|
conversation_messages=[],
|
|
)
|
|
test_db.add(session)
|
|
await test_db.commit()
|
|
|
|
manager = HandoffManager(test_db)
|
|
handoff = await manager.create_handoff(
|
|
session_id=session.id,
|
|
intent="park",
|
|
engineer_notes="waiting on customer",
|
|
user_id=test_user["user_data"]["id"],
|
|
)
|
|
await test_db.commit()
|
|
|
|
with patch(
|
|
"app.services.handoff_manager.EmailService.send_notification_email",
|
|
new=AsyncMock(return_value=True),
|
|
) as send:
|
|
sent = await manager.dispatch_escalation_notifications(handoff)
|
|
|
|
assert sent == 0
|
|
assert send.call_count == 0
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_dispatch_graceful_degradation_when_email_raises(
|
|
client: AsyncClient, test_user, auth_headers, test_db
|
|
):
|
|
"""If the email service raises (auth misconfig, network, etc.), dispatch
|
|
must NOT raise. Handoff creation has already committed; emailing is
|
|
best-effort. Codex-flagged regression."""
|
|
teammate = User(
|
|
email="t@example.com",
|
|
password_hash="x",
|
|
name="T",
|
|
role="engineer",
|
|
account_id=test_user["user_data"]["account_id"],
|
|
account_role="engineer",
|
|
)
|
|
test_db.add(teammate)
|
|
await test_db.flush()
|
|
|
|
session = AISession(
|
|
user_id=test_user["user_data"]["id"],
|
|
account_id=test_user["user_data"]["account_id"],
|
|
session_type="guided",
|
|
intake_type="free_text",
|
|
intake_content={"text": "x"},
|
|
status="active",
|
|
confidence_tier="discovery",
|
|
conversation_messages=[],
|
|
)
|
|
test_db.add(session)
|
|
await test_db.commit()
|
|
|
|
manager = HandoffManager(test_db)
|
|
handoff = await manager.create_handoff(
|
|
session_id=session.id,
|
|
intent="escalate",
|
|
engineer_notes="help",
|
|
user_id=test_user["user_data"]["id"],
|
|
)
|
|
await test_db.commit()
|
|
|
|
with patch(
|
|
"app.services.handoff_manager.EmailService.send_notification_email",
|
|
new=AsyncMock(side_effect=RuntimeError("SMTP down")),
|
|
):
|
|
# Must not raise.
|
|
sent = await manager.dispatch_escalation_notifications(handoff)
|
|
assert sent == 0
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_dispatch_publishes_to_escalation_bus(
|
|
client: AsyncClient, test_user, auth_headers, test_db
|
|
):
|
|
"""dispatch_escalation_notifications puts an event on the in-memory bus
|
|
so connected SSE subscribers see live arrivals."""
|
|
from app.core.escalation_bus import bus as escalation_bus
|
|
|
|
session = AISession(
|
|
user_id=test_user["user_data"]["id"],
|
|
account_id=test_user["user_data"]["account_id"],
|
|
session_type="guided",
|
|
intake_type="free_text",
|
|
intake_content={"text": "x"},
|
|
problem_summary="VPN down",
|
|
status="active",
|
|
confidence_tier="discovery",
|
|
conversation_messages=[],
|
|
)
|
|
test_db.add(session)
|
|
await test_db.commit()
|
|
|
|
manager = HandoffManager(test_db)
|
|
handoff = await manager.create_handoff(
|
|
session_id=session.id,
|
|
intent="escalate",
|
|
engineer_notes="please help",
|
|
user_id=test_user["user_data"]["id"],
|
|
)
|
|
await test_db.commit()
|
|
|
|
from uuid import UUID as PyUUID
|
|
account_id = PyUUID(test_user["user_data"]["account_id"])
|
|
|
|
queue = await escalation_bus.subscribe(account_id)
|
|
try:
|
|
with patch(
|
|
"app.services.handoff_manager.EmailService.send_notification_email",
|
|
new=AsyncMock(return_value=True),
|
|
):
|
|
await manager.dispatch_escalation_notifications(handoff)
|
|
|
|
import asyncio
|
|
event = await asyncio.wait_for(queue.get(), timeout=1.0)
|
|
assert event["type"] == "handoff_created"
|
|
assert event["handoff_id"] == str(handoff.id)
|
|
assert event["session_id"] == str(session.id)
|
|
assert event["priority"] == "normal"
|
|
finally:
|
|
await escalation_bus.unsubscribe(account_id, queue)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_create_handoff_endpoint_dispatches_on_escalate(
|
|
client: AsyncClient, test_user, auth_headers, test_db
|
|
):
|
|
"""End-to-end: POST /handoff with intent=escalate triggers
|
|
dispatch_escalation_notifications after commit. Verifies the wiring in
|
|
the endpoint, not just the manager method."""
|
|
teammate = User(
|
|
email="t2@example.com",
|
|
password_hash="x",
|
|
name="T2",
|
|
role="engineer",
|
|
account_id=test_user["user_data"]["account_id"],
|
|
account_role="engineer",
|
|
)
|
|
test_db.add(teammate)
|
|
await test_db.commit()
|
|
|
|
session = AISession(
|
|
user_id=test_user["user_data"]["id"],
|
|
account_id=test_user["user_data"]["account_id"],
|
|
session_type="guided",
|
|
intake_type="free_text",
|
|
intake_content={"text": "x"},
|
|
status="active",
|
|
confidence_tier="discovery",
|
|
conversation_messages=[],
|
|
)
|
|
test_db.add(session)
|
|
await test_db.commit()
|
|
|
|
with patch(
|
|
"app.services.handoff_manager.EmailService.send_notification_email",
|
|
new=AsyncMock(return_value=True),
|
|
) as send:
|
|
resp = await client.post(
|
|
f"/api/v1/ai-sessions/{session.id}/handoff",
|
|
headers=auth_headers,
|
|
json={"intent": "escalate", "engineer_notes": "Need help"},
|
|
)
|
|
assert resp.status_code == 201
|
|
assert send.call_count == 1
|
|
assert send.call_args.kwargs["to_email"] == "t2@example.com"
|