Stripe's compliance crawler fetches the apex URL without executing JS and declined live-mode review when `https://resolutionflow.com/` returned the empty SPA shell that redirected to /landing client-side. Restructure the router so / serves LandingPage directly: - `/` → new `PublicLanding` wrapper (LandingPage for anon; Navigate to /home for authed users so there's no marketing-frame flicker). - Authed tree converted to a path-less layout route with absolute child paths. QuickStartPage moves to `/home`; all other children (`/trees`, `/pilot`, `/admin/*`, `/account/*`, etc.) keep their URLs. - `/landing` kept as a one-release stale-bookmark redirect to /. - `ProtectedRoute` unauth redirect flipped /landing → /; `state.from` preserved for post-login return. Reference updates: - Post-login / post-onboarding destinations → /home: OAuthCallbackPage (incl. `?welcome=teammate` query), WelcomeStep1/2/3 dismiss-rest, AssistantChatPage post-escalate, WelcomeRouter completion/dismiss redirects, VerifyEmailPage's three "Go to dashboard" links. - Authed chrome → /home: TopBar logo, AppLayout mobile nav + drawer logo, CommandPalette Dashboard entry. - Dashboard onboarding → /home: NextStepCard `ran_session.ctaPath`, SetupChecklist `ran_session.path`, SessionHistoryPage empty-state CTA. - Public back-links → /: TermsPage, PrivacyPage, PoliciesPage, ContactPage, PromotionsPage, PublicTemplatesPage (header + footer). SharedSessionPage's `to="/"` left as-is — now correctly lands anon visitors on the public landing. Crawlability: - New `frontend/public/robots.txt` allowlisting public pages and disallowing the authed app. - New `frontend/public/sitemap.xml` for /, /pricing, /contact-sales, /contact, /templates, /terms, /privacy, /policies, /promotions. - `PageMeta` gains an `og:url` (defaults to `window.location.href`) and flips `twitter:card` to `summary_large_image` when an `ogImage` is passed. Tests: - `AppLayout.test.tsx` updated to mount at `/home`. - New `ProtectedRoute.test.tsx` asserts unauthenticated `/home` redirects to `/` (not `/landing`) and preserves origin in `state.from`. If Stripe's crawler still cannot see the site after this (zero-JS crawler), the documented next escalation is server-side prerendering of public routes via `vite-plugin-ssg`. Out of scope here. Plan: docs/plans/2026-05-13-public-landing-routing-refactor.md Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
60 lines
1.8 KiB
TypeScript
60 lines
1.8 KiB
TypeScript
import { describe, it, expect, beforeEach } from 'vitest'
|
|
import { render, screen } from '@testing-library/react'
|
|
import { MemoryRouter, Routes, Route, useLocation } from 'react-router-dom'
|
|
|
|
import { ProtectedRoute } from '../ProtectedRoute'
|
|
import { useAuthStore } from '@/store/authStore'
|
|
|
|
/**
|
|
* Probe component: surfaces the current pathname and `location.state.from` so
|
|
* the test can assert both the redirect target and that the original
|
|
* destination is preserved for post-login return.
|
|
*/
|
|
function LocationProbe() {
|
|
const loc = useLocation()
|
|
const from =
|
|
(loc.state as { from?: { pathname?: string } } | null)?.from?.pathname ?? ''
|
|
return (
|
|
<>
|
|
<div data-testid="probe-pathname">{loc.pathname}</div>
|
|
<div data-testid="probe-from">{from}</div>
|
|
</>
|
|
)
|
|
}
|
|
|
|
describe('ProtectedRoute — unauthenticated redirect', () => {
|
|
beforeEach(() => {
|
|
useAuthStore.setState({
|
|
user: null,
|
|
token: null,
|
|
isAuthenticated: false,
|
|
isLoading: false,
|
|
})
|
|
})
|
|
|
|
it('redirects unauthenticated visits to /home → / and preserves origin in state.from', () => {
|
|
render(
|
|
<MemoryRouter initialEntries={['/home']}>
|
|
<Routes>
|
|
<Route
|
|
path="/home"
|
|
element={
|
|
<ProtectedRoute>
|
|
<div data-testid="home-content">home</div>
|
|
</ProtectedRoute>
|
|
}
|
|
/>
|
|
<Route path="/" element={<LocationProbe />} />
|
|
</Routes>
|
|
</MemoryRouter>,
|
|
)
|
|
|
|
// The protected page should not render.
|
|
expect(screen.queryByTestId('home-content')).not.toBeInTheDocument()
|
|
|
|
// We landed on / (the public landing route), not /landing.
|
|
expect(screen.getByTestId('probe-pathname')).toHaveTextContent('/')
|
|
expect(screen.getByTestId('probe-from')).toHaveTextContent('/home')
|
|
})
|
|
})
|