Stripe's compliance crawler fetches the apex URL without executing JS and declined live-mode review when `https://resolutionflow.com/` returned the empty SPA shell that redirected to /landing client-side. Restructure the router so / serves LandingPage directly: - `/` → new `PublicLanding` wrapper (LandingPage for anon; Navigate to /home for authed users so there's no marketing-frame flicker). - Authed tree converted to a path-less layout route with absolute child paths. QuickStartPage moves to `/home`; all other children (`/trees`, `/pilot`, `/admin/*`, `/account/*`, etc.) keep their URLs. - `/landing` kept as a one-release stale-bookmark redirect to /. - `ProtectedRoute` unauth redirect flipped /landing → /; `state.from` preserved for post-login return. Reference updates: - Post-login / post-onboarding destinations → /home: OAuthCallbackPage (incl. `?welcome=teammate` query), WelcomeStep1/2/3 dismiss-rest, AssistantChatPage post-escalate, WelcomeRouter completion/dismiss redirects, VerifyEmailPage's three "Go to dashboard" links. - Authed chrome → /home: TopBar logo, AppLayout mobile nav + drawer logo, CommandPalette Dashboard entry. - Dashboard onboarding → /home: NextStepCard `ran_session.ctaPath`, SetupChecklist `ran_session.path`, SessionHistoryPage empty-state CTA. - Public back-links → /: TermsPage, PrivacyPage, PoliciesPage, ContactPage, PromotionsPage, PublicTemplatesPage (header + footer). SharedSessionPage's `to="/"` left as-is — now correctly lands anon visitors on the public landing. Crawlability: - New `frontend/public/robots.txt` allowlisting public pages and disallowing the authed app. - New `frontend/public/sitemap.xml` for /, /pricing, /contact-sales, /contact, /templates, /terms, /privacy, /policies, /promotions. - `PageMeta` gains an `og:url` (defaults to `window.location.href`) and flips `twitter:card` to `summary_large_image` when an `ogImage` is passed. Tests: - `AppLayout.test.tsx` updated to mount at `/home`. - New `ProtectedRoute.test.tsx` asserts unauthenticated `/home` redirects to `/` (not `/landing`) and preserves origin in `state.from`. If Stripe's crawler still cannot see the site after this (zero-JS crawler), the documented next escalation is server-side prerendering of public routes via `vite-plugin-ssg`. Out of scope here. Plan: docs/plans/2026-05-13-public-landing-routing-refactor.md Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
124 lines
3.4 KiB
TypeScript
124 lines
3.4 KiB
TypeScript
import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'
|
|
import { render, screen } from '@testing-library/react'
|
|
import { MemoryRouter, Routes, Route } from 'react-router-dom'
|
|
|
|
import { AppLayout } from '../AppLayout'
|
|
import { useAuthStore } from '@/store/authStore'
|
|
import type { User } from '@/types'
|
|
|
|
// Mock heavy/external pieces so this stays a focused integration test for the
|
|
// gate placement. We don't care that TopBar/Sidebar render real content here —
|
|
// only that the EmailVerificationGate is in the tree and gates the outlet.
|
|
vi.mock('@/hooks/useBillingPoll', () => ({
|
|
useBillingPoll: () => undefined,
|
|
}))
|
|
|
|
vi.mock('@/hooks/usePermissions', () => ({
|
|
usePermissions: () => ({ effectiveRole: 'engineer' }),
|
|
}))
|
|
|
|
vi.mock('../TopBar', () => ({
|
|
TopBar: () => <div data-testid="top-bar" />,
|
|
}))
|
|
|
|
vi.mock('../Sidebar', () => ({
|
|
Sidebar: () => <div data-testid="sidebar" />,
|
|
}))
|
|
|
|
vi.mock('../EmailVerificationBanner', () => ({
|
|
EmailVerificationBanner: () => <div data-testid="email-verification-banner-mock" />,
|
|
}))
|
|
|
|
vi.mock('@/components/common/FeedbackWidget', () => ({
|
|
FeedbackWidget: () => null,
|
|
}))
|
|
|
|
vi.mock('@/api/auth', () => ({
|
|
authApi: {
|
|
getVerificationStatus: vi.fn().mockResolvedValue({ enabled: true }),
|
|
sendVerificationEmail: vi.fn().mockResolvedValue(undefined),
|
|
},
|
|
}))
|
|
|
|
vi.mock('@/lib/toast', () => ({
|
|
toast: { success: vi.fn(), error: vi.fn() },
|
|
}))
|
|
|
|
function makeUser(overrides: Partial<User> = {}): User {
|
|
return {
|
|
id: 'user-1',
|
|
email: 'test@example.com',
|
|
name: 'Test User',
|
|
role: 'engineer',
|
|
is_super_admin: false,
|
|
is_active: true,
|
|
must_change_password: false,
|
|
account_id: 'acct-1',
|
|
account_role: 'engineer',
|
|
team_id: null,
|
|
created_at: '2026-05-01T00:00:00Z',
|
|
last_login: null,
|
|
phone: null,
|
|
job_title: null,
|
|
timezone: 'UTC',
|
|
avatar_url: null,
|
|
email_verified_at: null,
|
|
...overrides,
|
|
}
|
|
}
|
|
|
|
const FROZEN_NOW = new Date('2026-05-06T00:00:00Z')
|
|
|
|
function renderAppLayout() {
|
|
return render(
|
|
<MemoryRouter initialEntries={['/home']}>
|
|
<Routes>
|
|
<Route element={<AppLayout />}>
|
|
<Route
|
|
path="/home"
|
|
element={<div data-testid="child-route-content">child route</div>}
|
|
/>
|
|
</Route>
|
|
</Routes>
|
|
</MemoryRouter>,
|
|
)
|
|
}
|
|
|
|
describe('AppLayout — EmailVerificationGate wiring', () => {
|
|
beforeEach(() => {
|
|
vi.useFakeTimers()
|
|
vi.setSystemTime(FROZEN_NOW)
|
|
useAuthStore.setState({ user: null, token: null, isAuthenticated: false })
|
|
})
|
|
|
|
afterEach(() => {
|
|
vi.useRealTimers()
|
|
useAuthStore.setState({ user: null, token: null, isAuthenticated: false })
|
|
})
|
|
|
|
it('renders the wall and hides the child route on day 8 unverified', () => {
|
|
// created 8 days before frozen now -> elapsed=8, > grace=6 -> wall.
|
|
useAuthStore.setState({
|
|
user: makeUser({ created_at: '2026-04-28T00:00:00Z' }),
|
|
})
|
|
|
|
renderAppLayout()
|
|
|
|
expect(screen.getByTestId('email-verification-wall')).toBeInTheDocument()
|
|
expect(screen.queryByTestId('child-route-content')).not.toBeInTheDocument()
|
|
})
|
|
|
|
it('renders the child route within the grace period (day 1 unverified)', () => {
|
|
useAuthStore.setState({
|
|
user: makeUser({ created_at: '2026-05-05T00:00:00Z' }),
|
|
})
|
|
|
|
renderAppLayout()
|
|
|
|
expect(screen.getByTestId('child-route-content')).toBeInTheDocument()
|
|
expect(
|
|
screen.queryByTestId('email-verification-wall'),
|
|
).not.toBeInTheDocument()
|
|
})
|
|
})
|