Drop or wire up dead ?welcome=teammate query marker
#185
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Two sites write
?welcome=teammateas a marker for the dashboard to surface a teammate-welcome banner, but no consumer exists infrontend/src:frontend/src/pages/AcceptInvitePage.tsx:124—navigate('/?welcome=teammate', { replace: true })frontend/src/pages/OAuthCallbackPage.tsx:118—dest = '/home?welcome=teammate'Both sites annotate the marker as "decoded by the dashboard in Task 41" but no Task 41 consumer landed. The dashboard's onboarding UX is driven by
getOnboardingStatus, not URL state.This is the same dead-marker pattern we just dropped from
?welcome=trueand?verified=1in PR #174 — leaving these in invites the next reader to wonder whether they're load-bearing.Options
(a) Ship Task 41 — wire up a teammate-welcome banner on
/homethat decodes?welcome=teammateand shows a one-time greeting (then strips the param).(b) Drop the marker — remove
?welcome=teammatefrom both sites, simplifyAcceptInvitePage:124tonavigate('/home', { replace: true })(it's currently/which goes through PublicLanding's redirect flicker), and updateOAuthCallbackPage:118to plain/home.Acceptance
Either a real consumer renders something differentiated when
?welcome=teammateis present, or the marker is gone from the codebase.