chihlasm/resolutionflow
1
0
Fork 0
Code Issues 23 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Test coverage: WelcomeStep2 "Connect now" path #171

New Issue
Open
opened 2026-05-14 04:55:13 +00:00 by chihlasm · 0 comments
chihlasm commented 2026-05-14 04:55:13 +00:00
Owner
Copy Link

PR #168 reshaped the welcome step-2 PSA CTA from a single Continue + tiny Connect now → link into an explicit two-button split (Connect <PSA> now + Connect later). Existing tests in frontend/src/pages/welcome/__tests__/WelcomeStep2.test.tsx still pass because the welcome-step-2-connect-now testid is reused, but they only assert that the connect-now element exists — none of them exercise the new path:

  • Click welcome-step-2-tile-connectwise → click welcome-step-2-connect-now
  • Assert onboardingApi.updateStep called with {step: 2, action: 'complete', data: {primary_psa: 'connectwise'}}
  • Assert navigation to /account/integrations (route stub already exists in the test harness on line 68)

Also worth adding: a regression test that the welcome-step-2-connect-now button is hidden when primary_psa === 'none' (existing assertion just checks the testid isn't present, but should also verify the wider button row layout — only Continue + Skip this step rendered).

Small — single test file edit.

PR #168 reshaped the welcome step-2 PSA CTA from a single Continue + tiny `Connect now →` link into an explicit two-button split (`Connect <PSA> now` + `Connect later`). Existing tests in `frontend/src/pages/welcome/__tests__/WelcomeStep2.test.tsx` still pass because the `welcome-step-2-connect-now` testid is reused, but they only assert that the connect-now element exists — none of them exercise the new path: - Click `welcome-step-2-tile-connectwise` → click `welcome-step-2-connect-now` - Assert `onboardingApi.updateStep` called with `{step: 2, action: 'complete', data: {primary_psa: 'connectwise'}}` - Assert navigation to `/account/integrations` (route stub already exists in the test harness on line 68) Also worth adding: a regression test that the `welcome-step-2-connect-now` button is hidden when `primary_psa === 'none'` (existing assertion just checks the testid isn't present, but should also verify the wider button row layout — only `Continue` + `Skip this step` rendered). Small — single test file edit.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
10x-analysis
From 10x product analysis
 backend
FastAPI/Python work
 bug
Something isn't working
 collaboration
Team sharing, escalation, notifications
 database
PostgreSQL/schema changes
 documentation
Documentation updates
 duplicate
This issue or pull request already exists
 enhancement
Improvement to existing feature
 feature
New functionality
 frontend
React work
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 integration
PSA, external service integrations
 intelligence
Analytics, AI, data-driven features
 invalid
This doesn't seem right
 priority: high
Do this soon
 priority: low
Nice to have
 priority: medium
Important but not urgent
 question
Further information is requested
 quick-win
Low effort, high value
 strategic
Long-term strategic bet
 ux
User experience improvements
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
chihlasm
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: chihlasm/resolutionflow#171
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?