chihlasm/resolutionflow
1
0
Fork 0
Code Issues 23 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: resolve lint issues in maintenance schedule and editor page

Browse Source 
Move getScheduleSummary to scheduleUtils.ts to satisfy react-refresh
only-export-components rule. Add onScheduleLoaded to useEffect deps.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
chihlasm
2026-02-19 07:02:30 -05:00
parent 77ed045204
commit ef699f3eab
3 changed files with 27 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
frontend/src/components/procedural-editor/MaintenanceScheduleSection.tsx
View File

@@ -76,7 +76,7 @@ export function MaintenanceScheduleSection({ treeId, onScheduleLoaded }: Mainten
} }
} }
load() load()
}, [treeId]) }, [treeId, onScheduleLoaded])
const hydrateFromSchedule = (s: MaintenanceSchedule) => { const hydrateFromSchedule = (s: MaintenanceSchedule) => {
const parts = s.cron_expression.split(' ') const parts = s.cron_expression.split(' ')
@@ -239,26 +239,3 @@ export function MaintenanceScheduleSection({ treeId, onScheduleLoaded }: Mainten
</div> </div>
) )
} }
export function getScheduleSummary(schedule: MaintenanceSchedule | null, targetList?: TargetList | null): string {
if (!schedule) return 'No schedule configured'
const parts = schedule.cron_expression.split(' ')
const min = parts[0] ?? '0'
const hour = parts[1] ?? '0'
const timeStr = `${hour.padStart(2, '0')}:${min.padStart(2, '0')}`
const dayOfWeek = parts[4]
const dayOfMonth = parts[2]
let freqStr = 'Custom'
if (dayOfMonth === '1') {
freqStr = 'Monthly (1st)'
} else if (dayOfMonth === '*' && parts[3] === '*') {
if (dayOfWeek === '*') freqStr = 'Daily'
else if (dayOfWeek === '1') freqStr = 'Every Monday'
else if (dayOfWeek === '5') freqStr = 'Every Friday'
}
const targetStr = targetList ? ` \u00b7 ${targetList.targets.length} target${targetList.targets.length !== 1 ? 's' : ''}` : ''
return `${freqStr} at ${timeStr} ${schedule.timezone}${targetStr}`
}

24
frontend/src/components/procedural-editor/scheduleUtils.ts Normal file
View File

@@ -0,0 +1,24 @@
import type { MaintenanceSchedule, TargetList } from '@/types'
export function getScheduleSummary(schedule: MaintenanceSchedule | null, targetList?: TargetList | null): string {
if (!schedule) return 'No schedule configured'
const parts = schedule.cron_expression.split(' ')
const min = parts[0] ?? '0'
const hour = parts[1] ?? '0'
const timeStr = `${hour.padStart(2, '0')}:${min.padStart(2, '0')}`
const dayOfWeek = parts[4]
const dayOfMonth = parts[2]
let freqStr = 'Custom'
if (dayOfMonth === '1') {
freqStr = 'Monthly (1st)'
} else if (dayOfMonth === '*' && parts[3] === '*') {
if (dayOfWeek === '*') freqStr = 'Daily'
else if (dayOfWeek === '1') freqStr = 'Every Monday'
else if (dayOfWeek === '5') freqStr = 'Every Friday'
}
const targetStr = targetList ? ` \u00b7 ${targetList.targets.length} target${targetList.targets.length !== 1 ? 's' : ''}` : ''
return `${freqStr} at ${timeStr} ${schedule.timezone}${targetStr}`
}

3
frontend/src/pages/ProceduralEditorPage.tsx
View File

@@ -5,7 +5,8 @@ import { treesApi } from '@/api/trees'
import { useProceduralEditorStore } from '@/store/proceduralEditorStore' import { useProceduralEditorStore } from '@/store/proceduralEditorStore'
import { CollapsibleEditorSection } from '@/components/procedural-editor/CollapsibleEditorSection' import { CollapsibleEditorSection } from '@/components/procedural-editor/CollapsibleEditorSection'
import { IntakeFormBuilder } from '@/components/procedural-editor/IntakeFormBuilder' import { IntakeFormBuilder } from '@/components/procedural-editor/IntakeFormBuilder'
import { MaintenanceScheduleSection, getScheduleSummary } from '@/components/procedural-editor/MaintenanceScheduleSection' import { MaintenanceScheduleSection } from '@/components/procedural-editor/MaintenanceScheduleSection'
import { getScheduleSummary } from '@/components/procedural-editor/scheduleUtils'
import { StepList } from '@/components/procedural-editor/StepList' import { StepList } from '@/components/procedural-editor/StepList'
import { TagInput } from '@/components/common/TagInput' import { TagInput } from '@/components/common/TagInput'
import { toast } from '@/lib/toast' import { toast } from '@/lib/toast'