docs(handoff): PR #193 all 10 review findings resolved + 2 decisions

Findings doc gets a per-finding RESOLUTION section; HANDOFF resume point moves to
"re-push + merge" and corrects the false Task 16/17 "done" record; CURRENT_TASK
updated; two architectural decisions logged (real ai_build columns replacing the
meta convention; ad-hoc walk restored); SESSION_LOG entry added.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

.ai/HANDOFF.md

@@ -2,27 +2,30 @@
 
 # HANDOFF.md
 
-**Last updated:** 2026-05-30
+**Last updated:** 2026-06-09
 
-**Active task:** L1 AI Tree Builder **Phase 2A — COMPLETE**. All 19 plan tasks done on
-branch `feat/l1-ai-tree-builder-phase-2a` (branched from `main` @ `87236b5`), pushed to
-Gitea, **PR #193 open** (`main` ← `feat/l1-ai-tree-builder-phase-2a`, mergeable):
+**Active task:** L1 AI Tree Builder **Phase 2A — review findings RESOLVED, ready to re-push**.
+Branch `feat/l1-ai-tree-builder-phase-2a` (off `main` @ `87236b5`), **PR #193**:
 <https://gitea.resolutionflow.com/chihlasm/resolutionflow/pulls/193>.
 
-## Resume point — FIX REVIEW FINDINGS on PR #193, do NOT merge yet
+## Resume point — re-push the fixes, re-run CI, then merge
 
-A 2026-06-09 multi-agent review (7 finder angles, every finding code-verified) found
-**10 confirmed defects** — including a showstopper (AI-generated nodes carry no `id`,
-so ai_build walks can never advance past the first question) and proof that Tasks 16–17
-(ProposalDetail L1-source block, L1EscalationsSection mount) were recorded as done here
-but were **never committed**. Full findings, evidence (file:line), fixes, and execution
-order: [`docs/plans/2026-06-09-pr193-phase2a-review-findings.md`](../docs/plans/2026-06-09-pr193-phase2a-review-findings.md).
+All **10 review findings are resolved** (this session, uncommitted on the branch — commit +
+push are the next action). Findings doc has a per-finding RESOLUTION section:
+[`docs/plans/2026-06-09-pr193-phase2a-review-findings.md`](../docs/plans/2026-06-09-pr193-phase2a-review-findings.md).
+Two architecture decisions logged in `.ai/DECISIONS.md` (2026-06-09): real
+`category`/`problem_text`/`pending_node` columns replacing the `meta` walked_path
+convention; ad-hoc walk restored.
 
-Next session: work that doc top-to-bottom (findings 1–7 are merge blockers), re-run the
-Phase 2A test gate + tsc/lint/build + migration roundtrip, then resume the old plan:
-merge PR #193, prod `alembic upgrade head` (3 migrations, head `1fd88a68b145`), and the
-live AI-quality smoke test before wide enablement (spec §5.3 — all model calls are
-mocked in tests).
+Next: commit + push the branch, let Gitea CI run, then merge PR #193. After merge:
+prod `alembic upgrade head` — now **4 migrations**, new head **`61dda4f615c6`** (adds the
+three l1_walk_sessions columns + flips `flow_proposals.l1_session_id` FK to CASCADE + an
+escalations partial index). Then the live AI-quality smoke test before wide enablement
+(spec §5.3 — all model calls are mocked in tests).
+
+**Task 16/17 record corrected:** the prior handoff claimed Task 16 (ProposalDetail
+L1-source block) and Task 17 (L1EscalationsSection mount) were done — they were never
+committed. Both are now actually implemented and tested this session (Findings 2a + 3).
 
 ## What shipped (all verified this session)
 
@@ -32,9 +35,10 @@ mocked in tests).
   `normalize_walked_path`, skips `meta`), `match_or_build` (match-first, gate-on-build,
   flow_id→str), `l1_session_service` (start/advance ai_build storing `node_text`, flywheel
   capture on resolve, escalate notify). `l1.session.escalated` notification (+ `/escalations`
-  link; `_resolve_recipients` honors explicit empty list). API: intake dispatch (build seeds
-  a hidden `{"node_type":"meta","category":...}` walked_path entry), `/next-node`,
+  link; `_resolve_recipients` honors explicit empty list). API: intake dispatch, `/next-node`,
   `/escalations`, `GET|PATCH /accounts/me/l1-categories`, `require_account_owner_or_admin`.
+  (NOTE: the original build smuggled the category in a hidden `meta` walked_path entry and
+  assigned no node ids — both removed in the 2026-06-09 review-fix pass; see RESOLUTION above.)
 - **Frontend (Tasks 13–17):** l1 types/api (intake outcome, TreeNode, categories; nextNode
   carries `node_text`); L1Dashboard outcome dispatch; L1WalkTreeVariant AI-node rendering +
   disclaimer banner; owner-gated L1CategoriesPage + route + settings card; ProposalDetail
@@ -42,11 +46,14 @@ mocked in tests).
 - **Tests (Task 18 + throughout):** ~114 Phase 2A backend tests incl. an intake→build→
   walk→resolve→proposal / →escalate→notify→list integration test; network-stubbed e2e.
 
-**Verification (Task 19) — numbers below were read from complete run summaries:**
-- The 11 Phase 2A backend test files run together = **86 passed / 0 errors / 0 failed**
-  (`/tmp/p2a.txt`). This is the authoritative Phase-2A gate.
-- Frontend `tsc -b` + `npm run lint` + `npm run build` clean; migration `downgrade -3`
-  → `upgrade head` roundtrips cleanly.
+**Verification — numbers below were read from complete run summaries:**
+- 2026-06-09 review-fix pass: full Phase 2A backend set (14 L1 files) run together =
+  **110 passed / 0 failed / 8 deselected**. Frontend `tsc -b` + `eslint` + `vite build`
+  clean. Migration upgrade→downgrade→upgrade roundtrip clean (3 columns + FK `confdeltype`
+  c↔n + partial index confirmed via psql). Anti-parrot guardrail green.
+- (Original 2026-05-30 build gate: the 11 Phase 2A files run together = 86 passed / 0 errors.)
+- Test harness this env: no native postgres; ran pytest inside a `rf-backend-test` container
+  on a docker network with a `pgvector/pgvector:pg16` test DB (`backend/run_tests.sh` helper).
 - **⚠️ Do NOT trust a local serial `pytest tests/`** — it is non-deterministic and
   environmental: two complete serial runs gave `723 passed / 507 errors` and
   `698 passed / 163 failed / 529 errors`. The thousands of errors are asyncpg