Implement session outcomes, step timing, and live timer fixes
This commit is contained in:
@@ -153,12 +153,34 @@ class TestSessions:
|
||||
# Complete session
|
||||
response = await client.post(
|
||||
f"/api/v1/sessions/{session_id}/complete",
|
||||
json={"outcome": "resolved", "outcome_notes": "Issue fixed after restarting service"},
|
||||
headers=auth_headers
|
||||
)
|
||||
|
||||
assert response.status_code == 200
|
||||
data = response.json()
|
||||
assert data["completed_at"] is not None
|
||||
assert data["outcome"] == "resolved"
|
||||
assert data["outcome_notes"] == "Issue fixed after restarting service"
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_complete_session_requires_outcome(
|
||||
self, client: AsyncClient, auth_headers: dict, test_tree: dict
|
||||
):
|
||||
"""Test that completion requires an outcome payload."""
|
||||
create_response = await client.post(
|
||||
"/api/v1/sessions",
|
||||
json={"tree_id": test_tree["id"]},
|
||||
headers=auth_headers
|
||||
)
|
||||
session_id = create_response.json()["id"]
|
||||
|
||||
response = await client.post(
|
||||
f"/api/v1/sessions/{session_id}/complete",
|
||||
headers=auth_headers
|
||||
)
|
||||
|
||||
assert response.status_code == 422
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_complete_already_completed_session(
|
||||
@@ -175,12 +197,14 @@ class TestSessions:
|
||||
|
||||
await client.post(
|
||||
f"/api/v1/sessions/{session_id}/complete",
|
||||
json={"outcome": "resolved"},
|
||||
headers=auth_headers
|
||||
)
|
||||
|
||||
# Try to complete again
|
||||
response = await client.post(
|
||||
f"/api/v1/sessions/{session_id}/complete",
|
||||
json={"outcome": "resolved"},
|
||||
headers=auth_headers
|
||||
)
|
||||
|
||||
@@ -217,6 +241,59 @@ class TestSessions:
|
||||
assert "EXP-001" in content # Should contain ticket number
|
||||
assert "#" in content # Markdown headers
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_export_markdown_includes_outcome_and_step_duration(
|
||||
self, client: AsyncClient, auth_headers: dict, test_tree: dict
|
||||
):
|
||||
"""Test markdown export includes session outcome and per-step duration."""
|
||||
create_response = await client.post(
|
||||
"/api/v1/sessions",
|
||||
json={"tree_id": test_tree["id"], "ticket_number": "EXP-OUTCOME-001"},
|
||||
headers=auth_headers
|
||||
)
|
||||
session_id = create_response.json()["id"]
|
||||
|
||||
step_timestamp = "2026-02-11T10:10:00Z"
|
||||
update_response = await client.put(
|
||||
f"/api/v1/sessions/{session_id}",
|
||||
json={
|
||||
"decisions": [{
|
||||
"node_id": "root",
|
||||
"question": "Is this a test?",
|
||||
"answer": "Yes",
|
||||
"action_performed": None,
|
||||
"notes": "Validated quickly",
|
||||
"automation_used": False,
|
||||
"timestamp": step_timestamp,
|
||||
"entered_at": "2026-02-11T10:08:30Z",
|
||||
"exited_at": step_timestamp,
|
||||
"duration_seconds": 90,
|
||||
"attachments": []
|
||||
}]
|
||||
},
|
||||
headers=auth_headers
|
||||
)
|
||||
assert update_response.status_code == 200
|
||||
|
||||
complete_response = await client.post(
|
||||
f"/api/v1/sessions/{session_id}/complete",
|
||||
json={"outcome": "workaround", "outcome_notes": "Temporary mitigation applied"},
|
||||
headers=auth_headers
|
||||
)
|
||||
assert complete_response.status_code == 200
|
||||
|
||||
export_response = await client.post(
|
||||
f"/api/v1/sessions/{session_id}/export",
|
||||
json={"format": "markdown", "include_timestamps": True, "include_tree_info": True},
|
||||
headers=auth_headers
|
||||
)
|
||||
|
||||
assert export_response.status_code == 200
|
||||
content = export_response.text
|
||||
assert "**Outcome:** Workaround Applied" in content
|
||||
assert "**Duration:**" in content
|
||||
assert "**Duration:** 1m 30s" in content
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_export_session_text(
|
||||
self, client: AsyncClient, auth_headers: dict, test_tree: dict
|
||||
@@ -291,6 +368,7 @@ class TestSessions:
|
||||
# Complete first session
|
||||
await client.post(
|
||||
f"/api/v1/sessions/{session1_id}/complete",
|
||||
json={"outcome": "resolved"},
|
||||
headers=auth_headers
|
||||
)
|
||||
|
||||
@@ -449,6 +527,7 @@ class TestSessions:
|
||||
|
||||
await client.post(
|
||||
f"/api/v1/sessions/{session_id}/complete",
|
||||
json={"outcome": "resolved"},
|
||||
headers=auth_headers
|
||||
)
|
||||
|
||||
@@ -857,6 +936,7 @@ class TestSessions:
|
||||
|
||||
await client.post(
|
||||
f"/api/v1/sessions/{session_id}/complete",
|
||||
json={"outcome": "resolved"},
|
||||
headers=auth_headers
|
||||
)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user