chihlasm/resolutionflow
1
0
Fork 0
Code Issues 23 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: address code review issues in flow-to-library sync

Browse Source 
- Fix sync trigger: only fire on publish transition, not every PUT
- Add TestSyncOnPublish integration tests (2 tests, 16 total passing)
- Add group_label to frontend StepContent interface
- Guard Library Visibility select to procedure_step nodes only
- Block API edits to flow-synced steps (400 read-only guard)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
chihlasm
2026-02-25 14:01:10 -05:00
parent 09b8f07e1e
commit 8f32e7c667
5 changed files with 88 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
backend/app/api/endpoints/trees.py
View File

@@ -641,8 +641,8 @@ async def update_tree(
if "tree_structure" in update_data:
tree.version += 1
# Sync steps to step library when publishing
if update_data.get("status") == 'published' or tree.status == 'published':
# Sync steps to step library on publish transition only
if update_data.get("status") == 'published':
_structure = update_data.get("tree_structure", tree.tree_structure)
_type = update_data.get("tree_type", tree.tree_type)
_is_public = update_data.get("is_public", tree.is_public)