chihlasm/resolutionflow
1
0
Fork 0
Code Issues 23 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: resolve eslint immutability error in StepChecklist

Browse Source 
Pre-compute section header visibility before render instead of mutating
a variable during .map() callback, which violates react-hooks/immutability.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
chihlasm
2026-02-14 04:43:13 -05:00
parent 350c977eda
commit 6b4304ab92
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
frontend/src/components/procedural/StepChecklist.tsx
View File

@@ -11,15 +11,22 @@ interface StepChecklistProps {
export function StepChecklist({ steps, currentStepIndex, completedStepIds, onStepClick }: StepChecklistProps) { export function StepChecklist({ steps, currentStepIndex, completedStepIds, onStepClick }: StepChecklistProps) {
const procedureSteps = steps.filter((s) => s.type === 'procedure_step') const procedureSteps = steps.filter((s) => s.type === 'procedure_step')
let lastSection: string | undefined
// Pre-compute which steps should show a section header
const sectionVisibility = new Set<number>()
let prevSection: string | undefined
for (let i = 0; i < procedureSteps.length; i++) {
const header = procedureSteps[i].section_header
if (header && header !== prevSection) sectionVisibility.add(i)
if (header) prevSection = header
}
return ( return (
<nav className="space-y-0.5"> <nav className="space-y-0.5">
{procedureSteps.map((step, index) => { {procedureSteps.map((step, index) => {
const isCompleted = completedStepIds.has(step.id) const isCompleted = completedStepIds.has(step.id)
const isCurrent = index === currentStepIndex const isCurrent = index === currentStepIndex
const showSection = step.section_header && step.section_header !== lastSection const showSection = sectionVisibility.has(index)
if (step.section_header) lastSection = step.section_header
return ( return (
<div key={step.id}> <div key={step.id}>