fix: add auth guards, optimize refresh loop, and improve batch session tests
- Move mid-file pydantic/uuid imports to top of sessions.py - Add can_access_tree, is_active, and draft status guards to batch_launch_sessions - Remove notes field from _BatchTarget to keep API clean - Add max_length=100 cap to targets list in _BatchLaunchRequest - Hoist tree_snapshot computation above the session creation loop - Replace N db.refresh() calls with a single bulk select after flush - Add test_batch_launch_requires_auth and test_batch_launch_rejects_draft_tree tests - Fix trailing slash on /api/v1/trees/ URL in new test (caused 307 redirect) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -32,8 +32,8 @@ async def test_batch_launch_creates_one_session_per_target(client: AsyncClient,
|
||||
json={
|
||||
"tree_id": tree_id,
|
||||
"targets": [
|
||||
{"label": "RDS-01", "notes": "192.168.1.10"},
|
||||
{"label": "RDS-02", "notes": "192.168.1.11"},
|
||||
{"label": "RDS-01"},
|
||||
{"label": "RDS-02"},
|
||||
{"label": "RDS-03"},
|
||||
],
|
||||
},
|
||||
@@ -90,3 +90,43 @@ async def test_batch_launch_rejects_non_maintenance_tree(client: AsyncClient, au
|
||||
headers=auth_headers,
|
||||
)
|
||||
assert batch_resp.status_code == 400
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_batch_launch_requires_auth(client: AsyncClient):
|
||||
"""Unauthenticated batch launch returns 401."""
|
||||
resp = await client.post(
|
||||
"/api/v1/sessions/batch",
|
||||
json={"tree_id": "00000000-0000-0000-0000-000000000000", "targets": [{"label": "SRV-01"}]},
|
||||
)
|
||||
assert resp.status_code == 401
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_batch_launch_rejects_draft_tree(client: AsyncClient, auth_headers: dict):
|
||||
"""Batch launch against a draft maintenance tree returns 400."""
|
||||
# Create a maintenance tree — trees default to 'published', so we explicitly set draft
|
||||
resp = await client.post(
|
||||
"/api/v1/trees",
|
||||
json={
|
||||
"name": "Draft Maintenance",
|
||||
"tree_type": "maintenance",
|
||||
"status": "draft",
|
||||
"tree_structure": {
|
||||
"steps": [
|
||||
{"id": "s1", "type": "procedure_step", "title": "Step",
|
||||
"description": "Do it", "content_type": "action"},
|
||||
{"id": "end", "type": "procedure_end", "title": "Done"},
|
||||
]
|
||||
},
|
||||
},
|
||||
headers=auth_headers,
|
||||
)
|
||||
assert resp.status_code == 201, resp.text
|
||||
tree_id = resp.json()["id"]
|
||||
batch_resp = await client.post(
|
||||
"/api/v1/sessions/batch",
|
||||
json={"tree_id": tree_id, "targets": [{"label": "SRV-01"}]},
|
||||
headers=auth_headers,
|
||||
)
|
||||
assert batch_resp.status_code == 400
|
||||
|
||||
Reference in New Issue
Block a user