From 56b3f877c1bcafd6c799dfcf80bf6980a9789c4d Mon Sep 17 00:00:00 2001
From: chihlasm <michael@chihlas.com>
Date: Mon, 30 Mar 2026 04:38:33 +0000
Subject: [PATCH] fix: pre-landing and adversarial review fixes
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- landing.css: hardcode --lp-btn to #60a5fa (lesson 104 — no var(--color-*) in landing.css)
- ScriptBuilderInput: suggestion chips now correctly disabled during generation
- ChatSidebar: wrapper onClick no longer fires onSelect while in confirming state
- SessionHistoryPage: fix loadMoreAiSessions race condition with generation counter;
  flow session tab auto-activates when URL params target flow session filters

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 .../src/components/assistant/ChatSidebar.tsx  |  2 +-
 .../script-builder/ScriptBuilderInput.tsx     |  5 +++--
 frontend/src/pages/SessionHistoryPage.tsx     | 19 +++++++++++++++----
 frontend/src/styles/landing.css               |  2 +-
 4 files changed, 20 insertions(+), 8 deletions(-)

diff --git a/frontend/src/components/assistant/ChatSidebar.tsx b/frontend/src/components/assistant/ChatSidebar.tsx
index bea51f18..9c450050 100644
--- a/frontend/src/components/assistant/ChatSidebar.tsx
+++ b/frontend/src/components/assistant/ChatSidebar.tsx
@@ -189,7 +189,7 @@ function ChatItem({
 
   return (
     <div
-      onClick={onSelect}
+      onClick={confirming ? e => e.stopPropagation() : onSelect}
       className={cn(
         'group flex items-center gap-2 px-3 py-2.5 mx-1.5 rounded-lg cursor-pointer transition-colors',
         confirming
diff --git a/frontend/src/components/script-builder/ScriptBuilderInput.tsx b/frontend/src/components/script-builder/ScriptBuilderInput.tsx
index f4a7a527..87cf508d 100644
--- a/frontend/src/components/script-builder/ScriptBuilderInput.tsx
+++ b/frontend/src/components/script-builder/ScriptBuilderInput.tsx
@@ -92,8 +92,9 @@ export function ScriptBuilderInput({
             <button
               key={label}
               type="button"
-              onClick={() => onSend(label)}
-              className="group flex items-center gap-1.5 rounded-md border border-border bg-card px-3 py-1.5 text-xs text-muted-foreground transition-all hover:border-[var(--color-border-hover)] hover:bg-[var(--color-bg-elevated)] hover:text-foreground active:scale-[0.97]"
+              disabled={disabled}
+              onClick={() => { if (!disabled) onSend(label) }}
+              className="group flex items-center gap-1.5 rounded-md border border-border bg-card px-3 py-1.5 text-xs text-muted-foreground transition-all hover:border-[var(--color-border-hover)] hover:bg-[var(--color-bg-elevated)] hover:text-foreground active:scale-[0.97] disabled:opacity-50 disabled:cursor-not-allowed disabled:pointer-events-none"
             >
               <Icon size={11} className="text-muted shrink-0 group-hover:text-[#f97316] transition-colors" />
               {label}
diff --git a/frontend/src/pages/SessionHistoryPage.tsx b/frontend/src/pages/SessionHistoryPage.tsx
index 768e3f73..56699db7 100644
--- a/frontend/src/pages/SessionHistoryPage.tsx
+++ b/frontend/src/pages/SessionHistoryPage.tsx
@@ -29,7 +29,11 @@ type TabId = typeof TABS[number]['id']
 export default function SessionHistoryPage() {
   const navigate = useNavigate()
   const [searchParams, setSearchParams] = useSearchParams()
-  const [activeTab, setActiveTab] = useState<TabId>('ai')
+  const [activeTab, setActiveTab] = useState<TabId>(() => {
+    // If URL params target flow session filters, start on flows tab
+    const hasFlowParams = searchParams.get('ticket') || searchParams.get('client') || searchParams.get('tree')
+    return hasFlowParams ? 'flows' : 'ai'
+  })
 
   // ── AI Session state ──
   const [aiSessions, setAiSessions] = useState<AISessionSummary[]>([])
@@ -38,6 +42,7 @@ export default function SessionHistoryPage() {
   const [aiHasMore, setAiHasMore] = useState(false)
   const [aiSearchInput, setAiSearchInput] = useState('')
   const aiSearchTimeout = useRef<ReturnType<typeof setTimeout> | undefined>(undefined)
+  const aiFilterGenRef = useRef(0)
   const [aiFilters, setAiFilters] = useState({
     q: '',
     session_type: '',
@@ -85,6 +90,9 @@ export default function SessionHistoryPage() {
   // ── AI Sessions: fetch ──
   useEffect(() => {
     let cancelled = false
+    const gen = ++aiFilterGenRef.current
+    setAiSessions([])
+    setAiHasMore(false)
     const load = async () => {
       setAiLoading(true)
       try {
@@ -97,7 +105,7 @@ export default function SessionHistoryPage() {
           date_from: aiFilters.date_from || undefined,
           date_to: aiFilters.date_to ? `${aiFilters.date_to}T23:59:59.999Z` : undefined,
         })
-        if (!cancelled) {
+        if (!cancelled && gen === aiFilterGenRef.current) {
           setAiSessions(data)
           setAiHasMore(data.length >= PAGE_SIZE)
         }
@@ -112,6 +120,7 @@ export default function SessionHistoryPage() {
   }, [aiFilters])
 
   const loadMoreAiSessions = async () => {
+    const gen = aiFilterGenRef.current
     setAiLoadingMore(true)
     try {
       const data = await aiSessionsApi.listSessions({
@@ -124,8 +133,10 @@ export default function SessionHistoryPage() {
         date_from: aiFilters.date_from || undefined,
         date_to: aiFilters.date_to ? `${aiFilters.date_to}T23:59:59.999Z` : undefined,
       })
-      setAiSessions(prev => [...prev, ...data])
-      setAiHasMore(data.length >= PAGE_SIZE)
+      if (gen === aiFilterGenRef.current) {
+        setAiSessions(prev => [...prev, ...data])
+        setAiHasMore(data.length >= PAGE_SIZE)
+      }
     } catch {
       toast.error('Failed to load more sessions')
     } finally {
diff --git a/frontend/src/styles/landing.css b/frontend/src/styles/landing.css
index e80207a4..56f36fc1 100644
--- a/frontend/src/styles/landing.css
+++ b/frontend/src/styles/landing.css
@@ -19,7 +19,7 @@
   --lp-accent: #60a5fa;
   --lp-accent-soft: rgba(96, 165, 250, 0.10);
   --lp-accent-text: #93bbfc;
-  --lp-btn: var(--color-accent, #f97316);
+  --lp-btn: #60a5fa;
   --lp-success: #34d399;
   --lp-danger: #f87171;
   --lp-warning: #fbbf24;