chihlasm/resolutionflow
1
0
Fork 0
Code Issues 23 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: move Date.now() out of render in ErrorBoundary to satisfy eslint purity rule

Browse Source 
The chunk-reload logic used Date.now() and sessionStorage during render,
triggering react-hooks/purity. Moved to useEffect so side effects run
after commit, fixing the CI lint failure.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
chihlasm
2026-03-14 12:50:29 -04:00
parent 4d36eabfe3
commit 1e035ac375
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
frontend/src/components/common/ErrorBoundary.tsx
View File

@@ -1,5 +1,5 @@
import * as Sentry from '@sentry/react' import * as Sentry from '@sentry/react'
import { type ReactNode } from 'react' import { type ReactNode, useEffect, useRef } from 'react'
import { Button } from '@/components/ui/Button' import { Button } from '@/components/ui/Button'
interface FallbackProps { interface FallbackProps {
@@ -18,17 +18,20 @@ function isChunkLoadError(error: Error): boolean {
} }
function DefaultFallback({ error, resetError }: FallbackProps) { function DefaultFallback({ error, resetError }: FallbackProps) {
const reloadingRef = useRef(false)
// Auto-reload on stale chunk errors (happens after deployments) // Auto-reload on stale chunk errors (happens after deployments)
if (isChunkLoadError(error)) { useEffect(() => {
if (!isChunkLoadError(error)) return
const key = 'rf_boundary_chunk_reload' const key = 'rf_boundary_chunk_reload'
const lastReload = sessionStorage.getItem(key) const lastReload = sessionStorage.getItem(key)
const now = Date.now() const now = Date.now()
if (!lastReload || now - Number(lastReload) > 10_000) { if (!lastReload || now - Number(lastReload) > 10_000) {
sessionStorage.setItem(key, String(now)) sessionStorage.setItem(key, String(now))
reloadingRef.current = true
window.location.reload() window.location.reload()
return null
} }
} }, [error])
return ( return (
<div className="flex min-h-[400px] flex-col items-center justify-center p-8"> <div className="flex min-h-[400px] flex-col items-center justify-center p-8">