From 04ff2ea301a06be229ba9c40109aed75cc72a1f2 Mon Sep 17 00:00:00 2001
From: Michael Chihlas <michael@resolutionflow.com>
Date: Thu, 16 Apr 2026 21:28:48 +0000
Subject: [PATCH] fix(tickets): refresh status and resources in detail panel
 after update
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Status update was returning only new_status (string) and the parent list's
onStatusUpdated only set status_name. The <select> was bound to status_id,
which never changed — so it visually reverted to the old status even though
the PATCH succeeded.

- Backend: include new_status_id in the status-update response.
- Panel: own currentStatusId/currentStatusName state so the select reflects
  the change immediately and survives stale parent snapshots.
- Parent list: update status_id on both the row and selectedTicket so the
  list row stays in sync when the panel stays open.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 backend/app/schemas/psa_tickets.py             |  1 +
 backend/app/services/ticket_service.py         |  1 +
 .../components/tickets/TicketDetailPanel.tsx   | 18 +++++++++++++++---
 .../tickets/detail/TicketDetailHeader.tsx      | 14 ++++++++------
 frontend/src/pages/TicketsPage.tsx             |  9 +++++++--
 frontend/src/types/tickets.ts                  |  1 +
 6 files changed, 33 insertions(+), 11 deletions(-)

diff --git a/backend/app/schemas/psa_tickets.py b/backend/app/schemas/psa_tickets.py
index 91a37d73..0bb1565d 100644
--- a/backend/app/schemas/psa_tickets.py
+++ b/backend/app/schemas/psa_tickets.py
@@ -24,6 +24,7 @@ class PSATicketStatusUpdateSchema(BaseModel):
     ticket_id: int
     previous_status: str
     new_status: str
+    new_status_id: int
 
 
 class TicketCreatePayloadSchema(BaseModel):
diff --git a/backend/app/services/ticket_service.py b/backend/app/services/ticket_service.py
index 66e9552e..542c0b46 100644
--- a/backend/app/services/ticket_service.py
+++ b/backend/app/services/ticket_service.py
@@ -87,6 +87,7 @@ async def update_status(
         ticket_id=ticket_id,
         previous_status=previous_status,
         new_status=new_status,
+        new_status_id=status_id,
     )
 
 
diff --git a/frontend/src/components/tickets/TicketDetailPanel.tsx b/frontend/src/components/tickets/TicketDetailPanel.tsx
index 42125910..30736c80 100644
--- a/frontend/src/components/tickets/TicketDetailPanel.tsx
+++ b/frontend/src/components/tickets/TicketDetailPanel.tsx
@@ -16,7 +16,7 @@ import type { PSAResource } from '@/types/tickets'
 interface Props {
   ticket: PSATicketSearchResult
   onClose: () => void
-  onStatusUpdated?: (ticketId: number, newStatus: string) => void
+  onStatusUpdated?: (ticketId: number, newStatus: string, newStatusId: number) => void
   onSelectRelated?: (ticketId: number) => void
 }
 
@@ -37,6 +37,11 @@ export function TicketDetailPanel({ ticket, onClose, onStatusUpdated, onSelectRe
   const [contextLoading, setContextLoading] = useState(true)
   const [resourcesLoading, setResourcesLoading] = useState(true)
 
+  // Local status state so the select reflects updates immediately, independent
+  // of the parent list's stale `selectedTicket` snapshot.
+  const [currentStatusId, setCurrentStatusId] = useState<number | null>(ticket.status_id ?? null)
+  const [currentStatusName, setCurrentStatusName] = useState<string | null>(ticket.status_name ?? null)
+
   const ticketIdNum = Number(ticket.id)
 
   const loadResources = useCallback(() => {
@@ -51,6 +56,8 @@ export function TicketDetailPanel({ ticket, onClose, onStatusUpdated, onSelectRe
     setContext(null)
     setResources([])
     setStatuses([])
+    setCurrentStatusId(ticket.status_id ?? null)
+    setCurrentStatusName(ticket.status_name ?? null)
 
     Promise.all([
       psaContextApi.getTicketContext(ticketIdNum),
@@ -69,10 +76,13 @@ export function TicketDetailPanel({ ticket, onClose, onStatusUpdated, onSelectRe
         setContextLoading(false)
         setResourcesLoading(false)
       })
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [ticket.id, ticketIdNum])
 
-  function handleStatusUpdated(ticketId: number, newStatus: string) {
-    onStatusUpdated?.(ticketId, newStatus)
+  function handleStatusUpdated(ticketId: number, newStatus: string, newStatusId: number) {
+    setCurrentStatusId(newStatusId)
+    setCurrentStatusName(newStatus)
+    onStatusUpdated?.(ticketId, newStatus, newStatusId)
   }
 
   return (
@@ -96,6 +106,8 @@ export function TicketDetailPanel({ ticket, onClose, onStatusUpdated, onSelectRe
         {/* Header with status selector — optimistic, no loading gate */}
         <TicketDetailHeader
           ticket={ticket}
+          currentStatusId={currentStatusId}
+          currentStatusName={currentStatusName}
           statuses={statuses}
           onStatusUpdated={handleStatusUpdated}
         />
diff --git a/frontend/src/components/tickets/detail/TicketDetailHeader.tsx b/frontend/src/components/tickets/detail/TicketDetailHeader.tsx
index 83c0c523..0916dff0 100644
--- a/frontend/src/components/tickets/detail/TicketDetailHeader.tsx
+++ b/frontend/src/components/tickets/detail/TicketDetailHeader.tsx
@@ -6,11 +6,13 @@ import type { PSATicketStatusUpdate } from '@/types/tickets'
 
 interface Props {
   ticket: PSATicketSearchResult
+  currentStatusId: number | null
+  currentStatusName: string | null
   statuses: PSATicketStatusItem[]
-  onStatusUpdated: (ticketId: number, newStatus: string) => void
+  onStatusUpdated: (ticketId: number, newStatus: string, newStatusId: number) => void
 }
 
-export function TicketDetailHeader({ ticket, statuses, onStatusUpdated }: Props) {
+export function TicketDetailHeader({ ticket, currentStatusId, currentStatusName, statuses, onStatusUpdated }: Props) {
   const [updating, setUpdating] = useState(false)
 
   async function handleStatusChange(statusId: number) {
@@ -18,7 +20,7 @@ export function TicketDetailHeader({ ticket, statuses, onStatusUpdated }: Props)
     setUpdating(true)
     try {
       const result: PSATicketStatusUpdate = await ticketsApi.updateStatus(Number(ticket.id), statusId)
-      onStatusUpdated(result.ticket_id, result.new_status)
+      onStatusUpdated(result.ticket_id, result.new_status, result.new_status_id)
       toast.success(`Status updated to ${result.new_status}`)
     } catch {
       toast.error('Failed to update status')
@@ -48,7 +50,7 @@ export function TicketDetailHeader({ ticket, statuses, onStatusUpdated }: Props)
         {statuses.length > 0 ? (
           <select
             disabled={updating}
-            value={ticket.status_id ?? ''}
+            value={currentStatusId ?? ''}
             onChange={e => handleStatusChange(Number(e.target.value))}
             className="bg-input border border-default rounded-[5px] px-2 py-1 text-xs text-primary focus:border-accent focus:outline-none"
           >
@@ -57,9 +59,9 @@ export function TicketDetailHeader({ ticket, statuses, onStatusUpdated }: Props)
             ))}
           </select>
         ) : (
-          ticket.status_name && (
+          currentStatusName && (
             <span className="px-2 py-0.5 bg-elevated rounded text-xs text-muted-foreground">
-              {ticket.status_name}
+              {currentStatusName}
             </span>
           )
         )}
diff --git a/frontend/src/pages/TicketsPage.tsx b/frontend/src/pages/TicketsPage.tsx
index 52145ff2..256b0314 100644
--- a/frontend/src/pages/TicketsPage.tsx
+++ b/frontend/src/pages/TicketsPage.tsx
@@ -231,10 +231,15 @@ export default function TicketsPage() {
             <TicketDetailPanel
               ticket={selectedTicket}
               onClose={() => setSelectedTicket(null)}
-              onStatusUpdated={(ticketId, newStatus) => {
+              onStatusUpdated={(ticketId, newStatus, newStatusId) => {
                 setTickets(prev => prev.map(t =>
-                  t.id === String(ticketId) ? { ...t, status_name: newStatus } : t
+                  t.id === String(ticketId) ? { ...t, status_name: newStatus, status_id: newStatusId } : t
                 ))
+                setSelectedTicket(prev =>
+                  prev && prev.id === String(ticketId)
+                    ? { ...prev, status_name: newStatus, status_id: newStatusId }
+                    : prev
+                )
               }}
             />
           </div>
diff --git a/frontend/src/types/tickets.ts b/frontend/src/types/tickets.ts
index 0ba6d49b..a3664ac7 100644
--- a/frontend/src/types/tickets.ts
+++ b/frontend/src/types/tickets.ts
@@ -63,6 +63,7 @@ export interface PSATicketStatusUpdate {
   ticket_id: number
   previous_status: string
   new_status: string
+  new_status_id: number
 }
 
 export interface TicketListResponse {