From 0156aae6842b3551dd2a9398d8d0e4f4df284a92 Mon Sep 17 00:00:00 2001 From: Michael Chihlas Date: Fri, 1 May 2026 16:22:50 -0400 Subject: [PATCH] feat(session): impeccable session-screen pass + tasklane keyboard flow MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Multi-step UX refactor of the assistant chat session screen, run via the $impeccable skill. Heuristic score moved 24/40 → 33/40 (+9), with the biggest gains on Aesthetic & Minimalist (1→3), Consistency & Standards (1→3), and Recognition Rather Than Recall (2→4). Distill — chat region: - Remove the "Suggested checks" chip strip + selected-chip detail card; the TaskLane is the single canonical home for "what to do next" - Add an inline Next steps · N pending cue above the latest action-bearing AI bubble (anchors attention without duplicating the lane's items) - Link banner ↔ script-panel lifecycle: collapsing or dismissing the ProposalBanner now also hides the InlineNoTemplateDialog / TemplateMatchPanel - Drop backdrop-blur on the handoff-context overlay (DESIGN-SYSTEM hard rule) Quieter — drop decoration overshoot: - Remove 3px side stripes on TaskLane done cards, all 6 ProposalBanner modes, WhatWeKnowItem fact rows - Drop bg-gradient surfaces on WhatWeKnow + every ProposalBanner mode - Drop 2px accent borderTop on the TaskLane header - Replace bordered avatar boxes in banners with inline state-colored icons - Each surface now uses a single decoration channel (top border + inline icon) Layout: - Header consolidates to Resolve + Escalate + ⋯ kebab; Context, New Ticket, Update Ticket, Pause now live behind the kebab on desktop, with feature parity in the existing mobile overflow menu - Messages column anchors to max-w-3xl mx-auto to match the composer - Chat bubbles drop from rounded-2xl to rounded-xl for vocabulary alignment Typeset: - Unify text sizing from 14 distinct sizes (with sub-pixel oddities and rem/px duplicates) to a 5-step scale: 10px / 11px / text-xs / 13px / text-sm WhatWeKnow collapsible: - Header is now a toggle; section body hides when collapsed - Auto-collapses on first render when facts ≥ 5 so Questions / Diagnostic Checks stay above the fold - Engineer's choice persists in sessionStorage per session and beats the auto-collapse heuristic on subsequent renders - key=activeChatId on both render sites resets state cleanly across sessions Polish: - Split MessageCircleQuestion into Pencil (question Answer CTA, write affordance) + HelpCircle (per-check Explain toggle, universal help icon) — same icon for two different jobs was a discoverability bug - Drop redundant text-xs from font-sans text-[0.625rem] / text-[0.6875rem] double-class definitions; the more-specific size always wins TaskLane keyboard flow: - Enter submits and auto-advances to the next pending task; Shift+Enter inserts a newline (consistent across question and action textareas — paste events don't fire keydown, so paste-then-Enter still works as expected) - Esc cancels (same as the Cancel button) - After the last pending task is submitted, focus moves to the Send Responses button so the engineer can fire the whole batch with one more keystroke - Subtle hint row under each open input teaches the shortcut Type-check, lint, and build all clean. Co-Authored-By: Claude Opus 4.7 --- .../components/assistant/ActionCardGroup.tsx | 30 +- .../src/components/assistant/ChatMessage.tsx | 29 +- .../src/components/assistant/ChatSidebar.tsx | 8 +- .../assistant/ConcludeSessionModal.tsx | 8 +- .../assistant/SuggestedFlowCard.tsx | 4 +- .../src/components/assistant/TaskLane.tsx | 162 +++++--- .../src/components/pilot/ChatTabStrip.tsx | 2 +- .../src/components/pilot/ProposalBanner.tsx | 138 +++---- .../pilot/sections/AddNoteButton.tsx | 8 +- .../components/pilot/sections/WhatWeKnow.tsx | 113 ++++-- .../pilot/sections/WhatWeKnowItem.tsx | 8 +- frontend/src/pages/AssistantChatPage.tsx | 377 +++++++----------- 12 files changed, 442 insertions(+), 445 deletions(-) diff --git a/frontend/src/components/assistant/ActionCardGroup.tsx b/frontend/src/components/assistant/ActionCardGroup.tsx index 3af0619c..bf8dae4d 100644 --- a/frontend/src/components/assistant/ActionCardGroup.tsx +++ b/frontend/src/components/assistant/ActionCardGroup.tsx @@ -74,7 +74,7 @@ export function ActionCardGroup({ actions, onSubmit, disabled, stale }: ActionCa onClick={() => setExpanded(true)} className="w-full rounded-lg border border-default/50 bg-elevated/20 p-2.5 flex items-center justify-between text-left hover:bg-elevated/40 transition-colors group" > -
+
{pendingCount} diagnostic check{pendingCount !== 1 ? 's' : ''} — not completed
@@ -95,7 +95,7 @@ export function ActionCardGroup({ actions, onSubmit, disabled, stale }: ActionCa
{responses.map((r, i) => ( -
+
{r.state === 'done' ? ( ) : ( @@ -118,7 +118,7 @@ export function ActionCardGroup({ actions, onSubmit, disabled, stale }: ActionCa
{/* Command with copy button */} {action.command && response.state !== 'skipped' && (
- + {action.command} @@ -282,7 +282,7 @@ export function ActionCardGroup({ actions, onSubmit, disabled, stale }: ActionCa {submitError && ( -
+
Failed to send
@@ -203,7 +203,7 @@ function ChatItem({
{confirming ? (
- Delete? + Delete?